After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689671 - Reduce code-duplication in e_book_query_from_string()
Reduce code-duplication in e_book_query_from_string()
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
3.8.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks: 689622
 
 
Reported: 2012-12-05 00:35 UTC by Mathias Hasselmann (IRC: tbf)
Modified: 2013-09-14 16:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (7.38 KB, patch)
2012-12-05 00:35 UTC, Mathias Hasselmann (IRC: tbf) 		committed Details | Review

Description Mathias Hasselmann (IRC: tbf) 2012-12-05 00:35:49 UTC 
Created attachment 230709 [details] [review]
proposed patch

The attached patch reduces code-duplication in e_book_query_from_string() by merging almost identical sexp handlers used by that functions, and by merging two de-facto identical error branches.
Comment 1 Mathias Hasselmann (IRC: tbf) 2012-12-05 00:38:27 UTC 
Functionally this patch is not needed for resolving bug 689622. It just spawned while I worked on that bug and I currently also have that patch in the feature-branch for bug 689622...
Comment 2 Mathias Hasselmann (IRC: tbf) 2013-01-17 09:19:01 UTC 
Commited the patch: https://bugzilla.gnome.org/show_bug.cgi?id=689622#c8