GNOME Bugzilla – Bug 689612
Lower GLib version dependency to 2.32.
Last modified: 2019-02-22 06:00:59 UTC
Created attachment 230645 [details] [review] Lower GLib version dependency and provide fallback g_clear_pointer. We have to provide the g_clear_pointer implementation when GLib does not provide one.
Review of attachment 230645 [details] [review]: I think g_clear_pointer might have actually been introduced in GLIB 2.33 So maybe the check in configure.ac should be PKG_CHECK_EXISTS([glib-2.0 >= 2.33], [have_g_clear_pointer='yes'])
Even more correct would be to use 2.33.x, where x is actual micro version when g_clear_pointer was introduced. I felt bit too lazy to do the git archeology, so that's why I am checking against the first stable version having g_clear_pointer (odd minor version like 33 here means that library is unstable).
It seems to be present in Glib 2.33.1 which I guess is the first release of GLib 2.33, so glib-2.0 >= 2.33 should be okay. In any case, if I understand correctly, your patch won't break the build if the Glib version actually contains g_clear_pointer but is < 2.34. So setting glib-2.0 >= 2.33 will simply speed up configure for installations that have a version of glib 2.33.