After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689562 - vdpau: port to 1.0
vdpau: port to 1.0
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 691712
Blocks:
 
 
Reported: 2012-12-03 19:20 UTC by Arnaud
Modified: 2013-03-31 17:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
./configure log for gst-plugins-bad (38.74 KB, text/plain)
2012-12-03 19:20 UTC, Arnaud
Details
make log (executed at the top of the gst-plugins-bad tree) (43.75 KB, text/x-log)
2012-12-04 10:11 UTC, Arnaud
Details

Description Arnaud 2012-12-03 19:20:26 UTC
Created attachment 230567 [details]
./configure log for gst-plugins-bad

I tried several time to compile gstreamer from source to get vdpau working :
- tried to install 0.10 via package manager
- tried to compile from source using the tar file (packaged 12 days ago)
- tried to compile from uptodate sources using git

Last try :
- cloning building installing gstreamer
- cloning building installing gst-plugins-base
- cloning building installing gst-plugins-bad

everything compile and install with no error.
But no vdpau using the inspector.

You will find attached the result of the ./configure command for the gst-plugins-bad ==> seems vdpau is well detected on my machine

executing make in the sys/vdpau directory gives :

CC     libgstbasevideodecoder_la-gstvideoframe.lo
In file included from gstvideoframe.c:25:0:
gstvideoframe.h:81:3: error: expected specifier-qualifier-list before 'GstMiniObjectClass'
cc1: warnings being treated as errors
gstvideoframe.c: In function 'gst_video_frame_new':
gstvideoframe.c:38:3: error: implicit declaration of function 'gst_mini_object_new'
gstvideoframe.c:38:3: error: nested extern declaration of 'gst_mini_object_new'
gstvideoframe.c:38:11: error: cast to pointer from integer of different size
gstvideoframe.c: In function 'gst_video_frame_finalize':
gstvideoframe.c:53:3: error: implicit declaration of function 'GST_MINI_OBJECT_CLASS'
gstvideoframe.c:53:3: error: nested extern declaration of 'GST_MINI_OBJECT_CLASS'
gstvideoframe.c:53:55: error: invalid type argument of '->' (have 'int')
gstvideoframe.c: In function 'gst_video_frame_class_init':
gstvideoframe.c:74:3: error: 'GstMiniObjectClass' undeclared (first use in this function)
gstvideoframe.c:74:3: note: each undeclared identifier is reported only once for each function it appears in
gstvideoframe.c:74:23: error: 'mini_object_class' undeclared (first use in this function)
gstvideoframe.c:78:34: error: 'GstMiniObjectFinalizeFunction' undeclared (first use in this function)
gstvideoframe.c:79:7: error: expected ';' before 'gst_video_frame_finalize'
gstvideoframe.c: In function 'gst_video_frame_get_type':
gstvideoframe.c:101:53: error: 'GST_TYPE_MINI_OBJECT' undeclared (first use in this function)
gstvideoframe.c: At top level:
gstvideoframe.c:46:1: error: 'gst_video_frame_finalize' defined but not used
make[1]: *** [libgstbasevideodecoder_la-gstvideoframe.lo] Error 1
make[1]: Leaving directory `/home/arno/Desktop/gst-compile/git/gst-plugins-bad/sys/vdpau/basevideodecoder'
make: *** [all-recursive] Error 1
Comment 1 Tim-Philipp Müller 2012-12-03 21:22:58 UTC
It's not been ported to 1.0 yet. Edward is working on that. (Even the 0.10 version is not properly integrated with playbin/totem, for what it's worth).

If you just type 'make' in the top-level directory - does it break the build? Or not go into the vdpau directory, even though it said it would build it?
Comment 2 Arnaud 2012-12-04 10:11:48 UTC
Created attachment 230634 [details]
make log (executed at the top of the gst-plugins-bad tree)
Comment 3 Arnaud 2012-12-04 10:12:30 UTC
Make on the Top level does not break the build.
It simply does not go into vdpau directory.

See the enclosed make log.

Thanks.
Comment 4 Edward Hervey 2013-03-31 17:20:10 UTC
commit e3c71c65fe86b9810024980f19a422016eaf0b3c
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Thu Sep 20 19:03:11 2012 +0200

    vdpau: Port to 1.0
    
    New base class for vdpau decoders
    * mpeg2 ported and activated
    * h264 ported but deactivated
    * Uses GstMpegVideo meta
Comment 5 Tim-Philipp Müller 2013-03-31 17:21:15 UTC
vdpau is now ported to 1.0:


commit e3c71c65fe86b9810024980f19a422016eaf0b3c
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Thu Sep 20 19:03:11 2012 +0200

    vdpau: Port to 1.0
    
    New base class for vdpau decoders
    * mpeg2 ported and activated
    * h264 ported but deactivated
    * Uses GstMpegVideo meta

commit 2296296a51450c2db5581a09b9707a95fa149153
Author: Edward Hervey <edward@collabora.com>
Date:   Sun Dec 23 01:54:52 2012 +0100

    mpegvideoparse: Only add meta if downstream needs it
    
    It's not perfect, because in the cases where upstream doesn't
    initiate an allocation query, we won't know.

commit 14e7e78b7a67e57fcf77a7e13047394437ceae4d
Author: Edward Hervey <edward.hervey@collabora.co.uk>
Date:   Thu Sep 20 18:27:11 2012 +0200

    mpegvideoparse: Store information in GstMpegVideo12Meta
    
    FIXME : Only do so if we know downstream will need it

commit 67ac84c7b570750200b60cc5c1032c496298e564
Author: Edward Hervey <edward.hervey@collabora.co.uk>
Date:   Thu Sep 20 18:03:59 2012 +0200

    codecparsers: Add Mpeg Video GstMeta
    
    This can be used by parsers to provide pre-parsed information to
    downstream elements that would require it (so they can avoid having
    to parse the bitstream again).


The most interesting things are still missing (vdpauvideosink) and decoders other than MPEG-2 video, but we have bug #561225 and bug #623833 for that, so let's close this.