After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689495 - WorldClocks: use the new GWeather abilities to find if it's daytime or not
WorldClocks: use the new GWeather abilities to find if it's daytime or not
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-12-02 19:49 UTC by Giovanni Campagna
Modified: 2012-12-02 21:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
WorldClocks: use the new GWeather abilities to find if it's daytime or not (2.54 KB, patch)
2012-12-02 19:49 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-12-02 19:49:47 UTC 
GWeatherInfo has a new is_daytime() method, which does what gnome-clocks
needs and additionally accounts for locations within the polar circles.
Also, GWeatherInfo no longer requires an update to get astronomical data,
which means we can avoid hitting the network.
Comment 1 Giovanni Campagna 2012-12-02 19:49:49 UTC 
Created attachment 230461 [details] [review]
WorldClocks: use the new GWeather abilities to find if it's daytime or not
Comment 2 Paolo Borelli 2012-12-02 20:54:58 UTC 
Review of attachment 230461 [details] [review]:

I just mentioned this to weld on irc, but it looks like you beat him to it :-)

Looks great
Comment 3 Giovanni Campagna 2012-12-02 21:04:56 UTC 
Attachment 230461 [details] pushed as b332ba9 - WorldClocks: use the new GWeather abilities to find if it's daytime or not