After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689394 - Swipe scrolling in workspace view occasionally ends up in intermediate position
Swipe scrolling in workspace view occasionally ends up in intermediate position
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-30 23:56 UTC by Florian Müllner
Modified: 2013-02-20 16:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot after ending swipe scroll (587.42 KB, image/png)
2012-11-30 23:57 UTC, Florian Müllner
  Details
workspacesView: Treat 'gesture-cancel' the same as 'gesture-end' (1.43 KB, patch)
2013-02-20 11:51 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2012-11-30 23:56:42 UTC
See screenshot.
Comment 1 Florian Müllner 2012-11-30 23:57:51 UTC
Created attachment 230362 [details]
Screenshot after ending swipe scroll
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-11-30 23:59:52 UTC
Did you update Clutter? There were some patches that landed in there.
Comment 3 Florian Müllner 2012-12-01 00:09:00 UTC
Yes, but using the 3.8 moduleset. So those patches should probably land on the clutter-1.12 branch as well (unless the moduleset is switched to master)
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-12-01 00:22:57 UTC
I think it makes sense for gnome-shell master to track Clutter master, but let's ask Emmanuele in the morning.
Comment 5 Florian Müllner 2013-02-05 04:09:06 UTC
For what it's worth, I'm still seeing this problem (and we started to track Clutter master a while ago)
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-02-05 04:26:54 UTC
You need to be using clutter-1.14, actually, because clutter master is dead.

http://git.gnome.org/browse/clutter/commit/?id=75b521de6e3294bb612f08b1f191b0f75778d828

This commit fixes the issues I saw with swipe scrolling, but there could be another bug somewhere. Add logging to the pan-stopped signal handler?
Comment 7 Florian Müllner 2013-02-20 11:51:22 UTC
Created attachment 236918 [details] [review]
workspacesView: Treat 'gesture-cancel' the same as 'gesture-end'

When a swipe scroll completes, we scroll the active workspace into
view. This works fine if the gesture is completed properly by
emitting 'gesture-end', but not when Clutter considers the gesture
cancelled - in that case, the view remains stuck in an intermediate
position. To fix, treat 'gesture-cancel' the same as 'gesture-end'.
Comment 8 Jasper St. Pierre (not reading bugmail) 2013-02-20 16:31:44 UTC
Review of attachment 236918 [details] [review]:

Aha. Nice catch.
Comment 9 Florian Müllner 2013-02-20 16:44:10 UTC
Attachment 236918 [details] pushed as 420f010 - workspacesView: Treat 'gesture-cancel' the same as 'gesture-end'