After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689283 - Visual bugs with added cell comments and sheet names
Visual bugs with added cell comments and sheet names
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
git master
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2012-11-29 14:32 UTC by 12spahn46
Modified: 2013-04-20 00:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Too big comment text box in Gnumeric 1.11.90 (42.94 KB, image/png)
2012-11-29 19:53 UTC, 12spahn46
Details

Description 12spahn46 2012-11-29 14:32:23 UTC
Comment bug
-----------

What I did:

1. I enter a long line of text as a cell comment.
2. I put the mouse cursor over the red comment triangle.

Result: The text appears in a box which is by far to big for the entered text. Also no text wrapping occurs inside the text box.


Sheet name bug
--------------

The length for the three sheet name text fields in the bottom line is too short for the 'Sheet2' and 'Sheet3' names. That is, the last character is only seen half. I tried using a smaller font size, but the length problem did not disappear.

Thank you for correcting these two visual bugs in your next release.
Comment 1 Andreas J. Guelzow 2012-11-29 15:36:49 UTC
What do you mean by "far to big"?

Yes there is no automatic text wrapping. But of course you can add your own line-ends. The problem with automatic textwrap is that there are situations where the user wants to have a certain structure such as
blabla:  kkkkkkkkk kkk kk
blab: kkkkkkk kkkk kkkkk
Automatic text wrapping would mess that up.

The sheet name bug is a gtk bug (and happens with certain themes only).
Comment 2 12spahn46 2012-11-29 17:55:57 UTC
With 'far too big' I meant the following (see sketch below):

+-----------------------------------------------------------------+
|This is a very long line of text inside a Gnumeric comment box.  |
|                                                                 |
|                                                                 |
|                                                                 |
|                                                                 |
|                                                                 |
+-----------------------------------------------------------------+

Don't you think that the text box is too big for this one line of text? Also, why is it not possible in Gnumeric to adjust the comment box size as it is possible in all other spreadsheets I know?

By the way, both LibreOffice and Excel wrap text inside a comment box and the user can adjust the size of the comment box.
Comment 3 Andreas J. Guelzow 2012-11-29 19:11:59 UTC
I agree that what you have drawn is too big, but I don't see that. For me it looks like:

+-----------------------------------------------------------------+
|This is a very long line of text inside a Gnumeric comment box.  |
+-----------------------------------------------------------------+

Could you attach an example file with such a comment? If I can't replicate I can't really fix it.

The reason why it is not possible to adjust the comment box size in GNumeric is easy: nobody ever submitted a patch to implement that.
Comment 4 12spahn46 2012-11-29 19:53:57 UTC
Created attachment 230235 [details]
Too big comment text box in Gnumeric 1.11.90

By the way: I use Gnumeric on Fedora 18 Beta currently.
Comment 5 Andreas J. Guelzow 2012-11-29 20:45:49 UTC
Fedora 18 beta probably uses some ridiculously new gtk. I would suspect that this is a new "gtk feature" aka bug.

Which version of gtk are you using?
Comment 6 12spahn46 2012-11-29 21:27:53 UTC
On Fedora 18 Beta the following two gtk2/3 packages are installed:

gtk2-2.24.13-1.fc18.i686
gtk3-3.6.2-1.fc18.i686

These are probably the newest gtk2/3 versions.
Comment 7 Andreas J. Guelzow 2012-11-29 22:58:19 UTC
I am using 3.2.4 so you are probably seeing another behaviour change in GTK. Somebody with a more recent version of gtk who can replicate the issue will need to fix this problem.
Comment 8 Jean Bréfort 2012-11-30 07:07:14 UTC
I don't see that with 3.4.2
Comment 9 Morten Welinder 2013-04-18 02:13:17 UTC
I see the cell comment issue with 3.6.0
Comment 10 Morten Welinder 2013-04-18 13:26:28 UTC
...but not on 3.4.4.  There are no obvious changes in GtkTextView.c between
those two versions.

Strange.
Comment 11 Andreas J. Guelzow 2013-04-18 18:34:54 UTC
Morten, perhaps the difference is in GtkFrame (the GtkTextView is embedded in a GtkFrame):

		frame = gtk_frame_new (NULL);
		gtk_frame_set_shadow_type (GTK_FRAME (frame), GTK_SHADOW_NONE);

		gtk_container_add (GTK_CONTAINER (scg->comment.item), frame);
		gtk_container_add (GTK_CONTAINER (frame), text);
		gtk_widget_show_all (scg->comment.item);
Comment 12 Morten Welinder 2013-04-19 23:13:52 UTC
I temporarily pulled the frame out.  That's not it.
Comment 13 Morten Welinder 2013-04-20 00:35:32 UTC
I don't want to spend ages tracking this down, so I switched away from a
text view.

This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.