After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688960 - general: Add a few more accessibility relations
general: Add a few more accessibility relations
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-11-23 23:04 UTC by Jeremy Bicha
Modified: 2012-11-26 22:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
general: Add a few more accessibility relations (3.90 KB, patch)
2012-11-23 23:04 UTC, Jeremy Bicha
none Details | Review
general: Add a few more accessibility relations (3.96 KB, patch)
2012-11-26 00:26 UTC, Jeremy Bicha
committed Details | Review
color: Add another accessibility relation (958 bytes, patch)
2012-11-26 22:51 UTC, Jeremy Bicha
committed Details | Review
printers: Add more a11y relations, change 'Show' btn to 'Show Jobs' (3.28 KB, patch)
2012-11-26 22:51 UTC, Jeremy Bicha
committed Details | Review

Description Jeremy Bicha 2012-11-23 23:04:14 UTC
Adds more context for Orca navigation
Comment 1 Jeremy Bicha 2012-11-23 23:04:16 UTC
Created attachment 229744 [details] [review]
general: Add a few more accessibility relations
Comment 2 Matthias Clasen 2012-11-24 19:38:26 UTC
Review of attachment 229744 [details] [review]:

Looks reasonable, though it might be even better to just change the label from "Show" to "Show Jobs" - that helps the sighted population as well..
Comment 3 Jeremy Bicha 2012-11-26 00:26:51 UTC
Created attachment 229866 [details] [review]
general: Add a few more accessibility relations

And rename "Show" to "Show Jobs" in printer panel
Comment 4 Matthias Clasen 2012-11-26 22:09:55 UTC
Review of attachment 229866 [details] [review]:

Looks good to me
Comment 5 Matthias Clasen 2012-11-26 22:10:24 UTC
Review of attachment 229866 [details] [review]:

Should probably commit this as two separate commits though, one for each panel
Comment 6 Jeremy Bicha 2012-11-26 22:51:08 UTC
The following fixes have been pushed:
0b4d70d color: Add another accessibility relation
7e7a690 printers: Add more a11y relations, change 'Show' btn to 'Show Jobs'
Comment 7 Jeremy Bicha 2012-11-26 22:51:13 UTC
Created attachment 229954 [details] [review]
color: Add another accessibility relation
Comment 8 Jeremy Bicha 2012-11-26 22:51:17 UTC
Created attachment 229955 [details] [review]
printers: Add more a11y relations, change 'Show' btn to 'Show Jobs'