After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688831 - vm-creator: Only unpause VMs automatically on startup
vm-creator: Only unpause VMs automatically on startup
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: installer
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-11-21 19:03 UTC by Zeeshan Ali
Modified: 2016-03-31 13:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vm-creator: Only unpause VMs automatically on startup (1.68 KB, patch)
2012-11-21 19:03 UTC, Zeeshan Ali 		none Details | Review
vm-creator: Only unpause VMs automatically on startup (1.72 KB, patch)
2012-11-22 16:00 UTC, Zeeshan Ali 		none Details | Review
vm-creator: Only unpause VMs automatically on startup (1.72 KB, patch)
2012-11-22 16:09 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2012-11-21 19:03:04 UTC 
This fixes the issue of user unable to pause under-installation VMs
for good.
Comment 1 Zeeshan Ali 2012-11-21 19:03:06 UTC 
Created attachment 229591 [details] [review]
vm-creator: Only unpause VMs automatically on startup

This fixes the issue of user unable to pause under-installation VMs
for good.
Comment 2 Alexander Larsson 2012-11-22 15:22:08 UTC 
Review of attachment 229591 [details] [review]:

::: src/vm-creator.vala
@@ +26,3 @@
 
+        if (VMConfigurator.is_install_config (machine.domain_config))
+            machine.domain.start_async.begin (0, null);

Is it safe to start if the domain is already started? Otherwise this looks good.
Comment 3 Zeeshan Ali 2012-11-22 16:00:52 UTC 
Created attachment 229639 [details] [review]
vm-creator: Only unpause VMs automatically on startup

This version only starts the VM if its in saved state.
Comment 4 Zeeshan Ali 2012-11-22 16:09:11 UTC 
Created attachment 229640 [details] [review]
vm-creator: Only unpause VMs automatically on startup

This version only starts the domain if machine is in saved state.
Comment 5 Zeeshan Ali 2012-11-24 14:19:18 UTC 
Attached patch addressed the only issue pointed out in the review and I got an ACK on IRC:

<zeenix> [16:14:23] alex_away: so patch in bug#688831 all good now?
<bebot> [16:14:24] Bug http://bugzilla.gnome.org/show_bug.cgi?id=688831 normal, Normal, ---, gnome-boxes-maint, NEW, vm-creator: Only unpause VMs automatically on startup
<alex_away> [16:15:21] yeah, looks good

So I'll push this now..
Comment 6 Zeeshan Ali 2012-11-24 14:24:09 UTC 
Attachment 229640 [details] pushed as 30515e2 - vm-creator: Only unpause VMs automatically on startup