After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688684 - Check return value of write() in gck-debug.c and gcr-debug.c
Check return value of write() in gck-debug.c and gcr-debug.c
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-11-19 22:29 UTC by Mathias Hasselmann (IRC: tbf)
Modified: 2012-11-20 08:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.60 KB, patch)
2012-11-19 22:34 UTC, Mathias Hasselmann (IRC: tbf) 		committed Details | Review

Description Mathias Hasselmann (IRC: tbf) 2012-11-19 22:29:07 UTC 
With some recent version of libc*) the write() system call got marked with the warn_unused_result attribute. Because of that gcc now rejects gck-debug.c and gcr-debug.c in -Werror mode.

*) 2.15-0ubuntu20 here
Comment 1 Mathias Hasselmann (IRC: tbf) 2012-11-19 22:34:10 UTC 
Created attachment 229413 [details] [review]
proposed patch
Comment 2 Mathias Hasselmann (IRC: tbf) 2012-11-19 22:59:28 UTC 
Actually "recently" is relative... That attribute got added in 2005 already: http://sourceware.org/git/?p=glibc.git;a=commit;f=posix/unistd.h;h=0476597b28eaabb742a138c0551b93c5b69c6e5c

No the big, but side-tracking question is why gcc only started to complain now.
Comment 3 Stef Walter 2012-11-20 06:59:28 UTC 
Review of attachment 229413 [details] [review]:

Looks good. Please push to master.
Comment 4 Mathias Hasselmann (IRC: tbf) 2012-11-20 08:16:08 UTC 
thank you for review. merged.