After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688518 - gio-kqueue: use O_EVTONLY on MacOS
gio-kqueue: use O_EVTONLY on MacOS
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.34.x
Other OpenBSD
: Normal minor
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-11-17 08:46 UTC by Antoine Jacoutot
Modified: 2012-11-17 15:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use O_EVTONLY on MacOS (1.67 KB, patch)
2012-11-17 08:46 UTC, Antoine Jacoutot 		accepted-commit_now Details | Review

Description Antoine Jacoutot 2012-11-17 08:46:55 UTC 
Created attachment 229219 [details] [review]
use O_EVTONLY on MacOS

Hi.

MacOS X is able to open(2) a descriptor requested for event
notifications only by using the O_EVTONLY flag.

From the man page: the O_EVTONLY flag is only intended for monitoring a
file for changes (e.g. kqueue). Note: when this flag is used, the opened
file will not prevent an unmount of the volume that contains the file.

That means we don't need to exclude any file from monitoring. This patch
addresses that.

Would that be alright to push?
Comment 1 Colin Walters 2012-11-17 15:24:57 UTC 
Review of attachment 229219 [details] [review]:

Makes sense.
Comment 2 Antoine Jacoutot 2012-11-17 15:33:12 UTC 
Thanks Colin. Pushed as 596f96b.