After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688475 - st-theme-node-drawing: Group multiple cogl_rectangle calls
st-theme-node-drawing: Group multiple cogl_rectangle calls
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: st
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-16 16:19 UTC by drago01
Modified: 2012-11-16 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
st-theme-node-drawing: Group multiple cogl_rectangle calls (5.28 KB, patch)
2012-11-16 16:19 UTC, drago01 		committed Details | Review

Description drago01 2012-11-16 16:19:04 UTC 
See patch, just noticed it while working on something else.
Comment 1 drago01 2012-11-16 16:19:06 UTC 
Created attachment 229158 [details] [review]
st-theme-node-drawing: Group multiple cogl_rectangle calls

Calling cogl_rectangles is more efficent then using multiple cogl_rectangle calls.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-11-16 17:29:39 UTC 
Review of attachment 229158 [details] [review]:

Sure.
Comment 3 Giovanni Campagna 2012-11-16 17:43:33 UTC 
Review of attachment 229158 [details] [review]:

Are your sure about this assertion? Cogl seems to be batching VBO uploads through CoglJournal, unless you change the pipeline parameters, so this should not make any difference in practice.
Comment 4 drago01 2012-11-16 18:24:23 UTC 
(In reply to comment #3)
> Review of attachment 229158 [details] [review]:
> 
> Are your sure about this assertion? Cogl seems to be batching VBO uploads
> through CoglJournal, unless you change the pipeline parameters, so this should
> not make any difference in practice.

I didn't verify that in any case it does not hurt, saves a few function calls and allows cogl to optimize them better if there is a need to do so.
Comment 5 drago01 2012-11-16 18:25:22 UTC 
Attachment 229158 [details] pushed as 4fa914a - st-theme-node-drawing: Group multiple cogl_rectangle calls
Comment 6 drago01 2012-11-16 18:27:22 UTC 
Attachment 229158 [details] pushed as d854081 - st-theme-node-drawing: Group multiple cogl_rectangle calls