After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688415 - [textoverlay] Does not proxy the ALLOCATION query
[textoverlay] Does not proxy the ALLOCATION query
Status: RESOLVED DUPLICATE of bug 687459
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.x
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-11-15 17:40 UTC by Thibault Saunier
Modified: 2012-11-15 17:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Make textoverlay proxy ALLOCATION queries (951 bytes, patch)
2012-11-15 17:43 UTC, Thibault Saunier
none Details | Review

Description Thibault Saunier 2012-11-15 17:40:57 UTC
The textoverlay element does not proxy the ALLOCATION query. It will make the query not arrive stop at this element when an  upstream element do this query.

In the case of playbin2 for example, decoders will query allocation downstream to use a common bufferpool, but as there is a textoverlay on the way, it will never be able to use the pool from the sink. In the end useless memcopy happens in the sink because of the fact that sinks usually wait for buffers that have been allocated by its own pool (it is the case for xvimagesink and ximagesink at least).
Comment 1 Thibault Saunier 2012-11-15 17:43:48 UTC
Created attachment 229070 [details] [review]
Make textoverlay proxy ALLOCATION queries

This should apply on both 1.0 and master.
Comment 2 Tim-Philipp Müller 2012-11-15 17:47:51 UTC
This is fixed already, no?

*** This bug has been marked as a duplicate of bug 687459 ***