After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688279 - simple-slave: Don't create/destroy the initial-setup user
simple-slave: Don't create/destroy the initial-setup user
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2012-11-13 19:34 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-11-14 18:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
simple-slave: Don't create/destroy the initial-setup user (4.77 KB, patch)
2012-11-13 19:34 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-11-13 19:34:36 UTC 
We decided this was a bad idea, and it breaks SELinux as well.
The gnome-initial-setup package will install such a user.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-11-13 19:34:38 UTC 
Created attachment 228924 [details] [review]
simple-slave: Don't create/destroy the initial-setup user

We'll have a static user from here on out.
Comment 2 Ray Strode [halfline] 2012-11-13 19:38:34 UTC 
Review of attachment 228924 [details] [review]:

looks mostly okay. one thing:

::: daemon/gdm-simple-slave.c
@@ -1251,3 @@
-        }
-
-        if (g_remove (INITIAL_SETUP_TRIGGER_FILE) < 0) {

Doesn't this still need to get called?
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-11-14 16:35:22 UTC 
(In reply to comment #2)
> Review of attachment 228924 [details] [review]:
> 
> looks mostly okay. one thing:
> 
> ::: daemon/gdm-simple-slave.c
> @@ -1251,3 @@
> -        }
> -
> -        if (g_remove (INITIAL_SETUP_TRIGGER_FILE) < 0) {
> 
> Doesn't this still need to get called?

I wonder if gdm should be the one to remove the trigger file...
Comment 4 Ray Strode [halfline] 2012-11-14 16:39:00 UTC 
could go either way I guess, though, the more decoupled we can keep gdm and gnome-initial-setup, the cleaner the architecture will be, I suppose.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-11-14 18:15:46 UTC 
Attachment 228924 [details] pushed as 567f055 - simple-slave: Don't create/destroy the initial-setup user


I added such a capability to gnome-initial-setup, so I'm removing
the trigger file there.