After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688256 - a11y: also set the WM HighContrast theme when switch is flipped
a11y: also set the WM HighContrast theme when switch is flipped
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-13 14:35 UTC by Cosimo Cecchi
Modified: 2012-11-13 16:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
a11y: also set the WM HighContrast theme when switch is flipped (4.50 KB, patch)
2012-11-13 14:35 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2012-11-13 14:35:34 UTC 
See attached patch
Comment 1 Cosimo Cecchi 2012-11-13 14:35:36 UTC 
Created attachment 228897 [details] [review]
a11y: also set the WM HighContrast theme when switch is flipped

Now that we have a HighContrast-specific WM theme.
Comment 2 Florian Müllner 2012-11-13 16:02:18 UTC 
Review of attachment 228897 [details] [review]:

Looks good

::: js/ui/status/accessibility.js
@@ +114,3 @@
             hasHC,
+            interfaceSettings.is_writable(KEY_GTK_THEME) && interfaceSettings.is_writable(KEY_ICON_THEME) &&
+            wmSettings.is_writable(KEY_WM_THEME),

Nit: wrap after each condition or not at all
Comment 3 Cosimo Cecchi 2012-11-13 16:25:25 UTC 
Attachment 228897 [details] pushed as 65edbc1 - a11y: also set the WM HighContrast theme when switch is flipped

Thanks, pushed.