After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688181 - Minor loginDialog fixes
Minor loginDialog fixes
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-12 16:03 UTC by Florian Müllner
Modified: 2012-11-12 17:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
loginDialog: Remove the correct focus root from ctrl-alt-tab (894 bytes, patch)
2012-11-12 16:03 UTC, Florian Müllner
committed Details | Review
loginDialog: Fix yet another StIconType removal fallout (965 bytes, patch)
2012-11-12 16:03 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2012-11-12 16:03:48 UTC
See patches.
Comment 1 Florian Müllner 2012-11-12 16:03:51 UTC
Created attachment 228785 [details] [review]
loginDialog: Remove the correct focus root from ctrl-alt-tab

Commit 3abfcda8b5998d10 fixed the focus root passed to addGroup(),
but left the one in removeGroup() unchanged.
Comment 2 Florian Müllner 2012-11-12 16:03:54 UTC
Created attachment 228786 [details] [review]
loginDialog: Fix yet another StIconType removal fallout
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-11-12 17:06:34 UTC
Review of attachment 228785 [details] [review]:

tsk tsk
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-11-12 17:06:48 UTC
Review of attachment 228786 [details] [review]:

butts
Comment 5 Florian Müllner 2012-11-12 17:45:39 UTC
Attachment 228785 [details] pushed as 063bbb0 - loginDialog: Remove the correct focus root from ctrl-alt-tab
Attachment 228786 [details] pushed as fae4cb9 - loginDialog: Fix yet another StIconType removal fallout