After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688061 - When opening gnome-screenshot via hotkey, the name field is highlighted but does not have text focus.
When opening gnome-screenshot via hotkey, the name field is highlighted but d...
Status: VERIFIED FIXED
Product: gnome-screenshot
Classification: Core
Component: general
3.6.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-screenshot-maint
gnome-screenshot-maint
: 694190 700075 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-11-10 22:34 UTC by Chris Wayne
Modified: 2013-05-10 17:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix file name field in dialog not having focus initially (838 bytes, patch)
2013-04-05 19:17 UTC, Robin Stocker
committed Details | Review

Description Chris Wayne 2012-11-10 22:34:21 UTC
When running gnome-screenshot from hotkeys (and likely without), the save as dialog appears, and the name of the file to be saved is highlighted. This will make the user think this text box is active, and that typing will change the file name. This is not the case, as the text box does not have focus.
Comment 1 Robin Stocker 2013-04-05 19:03:12 UTC
Confirmed with master. Patch upcoming.
Comment 2 Robin Stocker 2013-04-05 19:17:59 UTC
Created attachment 240786 [details] [review]
Fix file name field in dialog not having focus initially

Patch against gnome-screenshot master which fixes this.
Comment 3 Cosimo Cecchi 2013-04-05 19:29:42 UTC
Review of attachment 240786 [details] [review]:

Looks good, but you should also set the save button as receives-default = TRUE, so that pressing Enter in the entry goes ahead and saves the file.
The entry already has activates_default = TRUE.
Comment 4 Robin Stocker 2013-04-05 20:05:21 UTC
(In reply to comment #3)
> Looks good, but you should also set the save button as receives-default = TRUE,
> so that pressing Enter in the entry goes ahead and saves the file.
> The entry already has activates_default = TRUE.

Hm, I tried that now, but it still does not work. Either I'm not running this thing the right way or there is another problem.
Comment 5 Cosimo Cecchi 2013-04-05 20:58:25 UTC
Yes, there was another problem preventing keyboard activation to work properly, which I fixed now in git. I also applied your patch on top. Thanks! Closing this as FIXED.

Attachment 240786 [details] pushed as 046f57e - Fix file name field in dialog not having focus initially
Comment 6 Robin Stocker 2013-04-05 21:23:29 UTC
Thanks! Verified that this fixes it. Will this get into 3.8.1?
Comment 7 Robin Stocker 2013-04-05 21:24:16 UTC
*** Bug 694190 has been marked as a duplicate of this bug. ***
Comment 8 Cosimo Cecchi 2013-04-05 22:21:19 UTC
Yeah I will include those fixes in 3.8.1.
Comment 9 Cosimo Cecchi 2013-05-10 17:44:46 UTC
*** Bug 700075 has been marked as a duplicate of this bug. ***