After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687995 - GUPnPIgd-1.0.gir build is not 'make -j' safe
GUPnPIgd-1.0.gir build is not 'make -j' safe
Status: RESOLVED FIXED
Product: gupnp-igd
Classification: Other
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-11-09 15:01 UTC by Allison Karlitskaya (desrt)
Modified: 2019-02-22 06:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gir build: depend on library for 'make -j' safety (825 bytes, patch)
2012-11-09 15:02 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2012-11-09 15:01:41 UTC
The rules to make GUPnPIgd-1.0.gir don't declare a dependency on libgupnp-igd-1.0.la which means that when running under 'make -j' it's possible that make will try to build the GIR before the library is done.

That looks like this:

  GISCAN GUPnPIgd-1.0.gir
  CCLD   libgupnp-igd-1.0.la
libtool: link: cannot find the library `libgupnp-igd-1.0.la' or unhandled argument `libgupnp-igd-1.0.la'
linking of temporary binary failed: Command '['/bin/bash', '../libtool', '--mode=link', '--tag=CC', '--silent', 'gcc', '-o', '/home/desrt/jhbuild/checkout/gupnp-igd/libgupnp-igd/tmp-introspectCxjkc2/GUPnPIgd-1.0', '-export-dynamic', '-L/opt/ca/desrt/gnome-3.8/lib', '/home/desrt/jhbuild/checkout/gupnp-igd/libgupnp-igd/tmp-introspectCxjkc2/GUPnPIgd-1.0.o', '-L.', 'libgupnp-igd-1.0.la', '-Wl,--export-dynamic', '-pthread', '-L/opt/ca/desrt/gnome-3.8//lib', '-lgio-2.0', '-lgobject-2.0', '-lgmodule-2.0', '-lrt', '-lglib-2.0', '-lgupnp-1.0']' returned non-zero exit status 1
make[3]: *** [GUPnPIgd-1.0.gir] Error 1
make[3]: *** Waiting for unfinished jobs....
Comment 1 Allison Karlitskaya (desrt) 2012-11-09 15:02:21 UTC
Created attachment 228575 [details] [review]
gir build: depend on library for 'make -j' safety

Don't attempt to build the .gir file before the .la is done.
Comment 2 Olivier Crête 2012-11-09 15:39:21 UTC
Will be in 0.2.2

commit 71624fbb7be2266298e33a45028ce0b5c1a54bd0
Author: Ryan Lortie <desrt@desrt.ca>
Date:   Fri Nov 9 10:01:44 2012 -0500

    gir build: depend on library for 'make -j' safety
    
    Don't attempt to build the .gir file before the .la is done.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=687995