After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687979 - dbus: Handle empty secrets correctly
dbus: Handle empty secrets correctly
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2012-11-09 11:14 UTC by Stef Walter
Modified: 2012-11-12 07:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
dbus: Handle empty secrets correctly (1.39 KB, patch)
2012-11-09 11:14 UTC, Stef Walter
committed Details | Review

Description Stef Walter 2012-11-09 11:14:25 UTC
We were doing a critical when an empty secret was returned from the store
and returning a failure. Having a null value returned from
gck_session_wrap_key_full() is not an error.
Comment 1 Stef Walter 2012-11-09 11:14:28 UTC
Created attachment 228552 [details] [review]
dbus: Handle empty secrets correctly

 * Don't assume an error occurred when retrieving an empty
   secret from the store.
Comment 2 Stef Walter 2012-11-12 07:31:22 UTC
Attachment 228552 [details] pushed as ac2df1e - dbus: Handle empty secrets correctly