After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687970 - gnome-shell shouldn't show empty categories
gnome-shell shouldn't show empty categories
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-09 10:43 UTC by Pacho Ramos
Modified: 2012-12-02 19:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
2.png (505.10 KB, image/png)
2012-11-09 10:43 UTC, Pacho Ramos
  Details
bug-687970.gz (26.93 KB, application/x-gzip)
2012-11-13 20:46 UTC, Pacho Ramos
  Details
appDisplay: do not show empty categories (1.82 KB, patch)
2012-11-16 07:32 UTC, Stéphane Démurget
committed Details | Review

Description Pacho Ramos 2012-11-09 10:43:19 UTC
Created attachment 228537 [details]
2.png

As you can see in attached screenshot, a category "Others" is listed even if it's empty, in that case, why should empty categories even shown?

Thanks
Comment 1 Stéphane Démurget 2012-11-09 11:27:13 UTC
Which distribution do you use?

The only applications of the Other categories might be hidden.
Can you attach an archive of your desktop files with:

    grep -vr "\(Name\|Comment\|Keywords\)" /usr/share/applications/ ~/.local/share/applications/ /usr/share/desktop-directories/ | gzip -9 > bug-687970.gz

That could help to nail down the issue quickly.
Comment 2 Pacho Ramos 2012-11-13 20:46:36 UTC
Created attachment 228931 [details]
bug-687970.gz

It's Ubuntu 12.04
Comment 3 Stéphane Démurget 2012-11-16 07:32:44 UTC
Created attachment 229112 [details] [review]
appDisplay: do not show empty categories

Desktop files can specify if the application should only be shown for
specified desktops with OnlyShowIn and NotShowIn directives options.

If a menu category only contained entries for a different desktop, we
were still creating the category.

We now only add a category button if there is at least one application
to be displayed in this category.
Comment 4 Giovanni Campagna 2012-11-20 16:04:19 UTC
Review of attachment 229112 [details] [review]:

Note that usually this is handled by libgmenu, except that the Other category is special (it is mentioned in <layout> to be explicitly at the end).
Anyway this is fine.
Comment 5 Stéphane Démurget 2012-11-20 20:19:32 UTC
Comment on attachment 229112 [details] [review]
appDisplay: do not show empty categories

Attachment 229112 [details] pushed as e6a3958 - appDisplay: do not show empty categories
Comment 6 Stéphane Démurget 2012-11-20 20:20:12 UTC
Pacho, this problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 7 Pacho Ramos 2012-11-20 20:30:05 UTC
Thanks for your attention and work :)
Comment 8 Jasper St. Pierre (not reading bugmail) 2012-12-02 19:15:55 UTC
I'd prefer to revert this and handle it in gmenu. Even though the "Other" category is special, it still should not show up.