After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687472 - video-blend: fix memory leak
video-blend: fix memory leak
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-11-02 19:09 UTC by Miguel Angel Cabrera Moya
Modified: 2012-11-02 19:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (1.04 KB, patch)
2012-11-02 19:10 UTC, Miguel Angel Cabrera Moya 		committed Details | Review

Description Miguel Angel Cabrera Moya 2012-11-02 19:09:10 UTC 
There is a memory leak if the g_return_if_fail check fails
Comment 1 Miguel Angel Cabrera Moya 2012-11-02 19:10:19 UTC 
Created attachment 227919 [details] [review]
proposed fix
Comment 2 Tim-Philipp Müller 2012-11-02 19:46:55 UTC 
(I'm committing this despite my comments re. g_return_*() on the other bug because this patch doesn't add extra checks and is nicer from a code style point of view too IMHO).
Comment 3 Tim-Philipp Müller 2012-11-02 19:47:08 UTC 
commit 2d8edb1e865e1f2ab117fba6c1e5d9a09c810618
Author: Miguel Angel Cabrera Moya <madmac2501@gmail.com>
Date:   Fri Nov 2 20:09:21 2012 +0100

    video-blend: fix memory leak when called with invalid parameters
    
    https://bugzilla.gnome.org/show_bug.cgi?id=687472