After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687449 - switch video input is sensitive even though I only have one camera
switch video input is sensitive even though I only have one camera
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: VoIP
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on: 687928
Blocks:
 
 
Reported: 2012-11-02 14:52 UTC by Andreas Nilsson
Modified: 2012-11-09 11:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
camera-menu: Show the menu only if there is more than one camera (1.16 KB, patch)
2012-11-08 13:52 UTC, Debarshi Ray
none Details | Review
camera-menu: Show the menu only if there is more than one camera (1.15 KB, patch)
2012-11-08 15:47 UTC, Debarshi Ray
none Details | Review
camera-menu: Show the menu only if there is more than one camera (1.20 KB, patch)
2012-11-08 22:38 UTC, Debarshi Ray
committed Details | Review

Description Andreas Nilsson 2012-11-02 14:52:57 UTC
For the menu in my preview, I get the option to switch camera, even though I only have one camera on this computer.
Comment 1 Debarshi Ray 2012-11-08 13:52:17 UTC
Created attachment 228466 [details] [review]
camera-menu: Show the menu only if there is more than one camera
Comment 2 Will Thompson 2012-11-08 14:12:19 UTC
Review of attachment 228466 [details] [review]:

My main concern here is what happens if you unplug the camera in use, leaving only one other camera (and hence hiding the menu). Does something sensible happen? Or do you get stuck with no camera selected, and with no way to select the sole remaining camera? (Not that I'm saying this is a reason to keep a menu around containing one camera.)
Comment 3 Debarshi Ray 2012-11-08 15:46:47 UTC
It crashes if you yank out the current camera (see 687928). The expected behaviour is to carry on with only audio, and then use the remaining camera (if any) for subsequent calls.
Comment 4 Debarshi Ray 2012-11-08 15:47:16 UTC
Created attachment 228483 [details] [review]
camera-menu: Show the menu only if there is more than one camera
Comment 5 Debarshi Ray 2012-11-08 22:38:06 UTC
Created attachment 228514 [details] [review]
camera-menu: Show the menu only if there is more than one camera
Comment 6 Guillaume Desmottes 2012-11-09 09:03:04 UTC
Review of attachment 228514 [details] [review]:

++ (stable and master); thanks for the patch !
Comment 7 Debarshi Ray 2012-11-09 11:01:58 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.