After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687361 - Irc account edit dialog improvements
Irc account edit dialog improvements
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-01 17:27 UTC by Michael Wood
Modified: 2012-11-02 09:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Attach dialog to parent window (1016 bytes, patch)
2012-11-01 17:27 UTC, Michael Wood 		committed Details | Review
Make sure the port GtkSpinButton gets enough space (2.18 KB, patch)
2012-11-01 17:28 UTC, Michael Wood 		committed Details | Review
Don't allow window resizing (892 bytes, patch)
2012-11-01 17:28 UTC, Michael Wood 		committed Details | Review

Description Michael Wood 2012-11-01 17:27:22 UTC 
Created attachment 227829 [details] [review]
Attach dialog to parent window

irc-network-dialog:
 - Don't allow window resizing    
    Resizing causes blank space issues with the dialog.

 - Make sure the port GtkSpinButton gets enough space
    
    Column expanding was causing the port cell to be eclipsed by the port
    spin +/- buttons.

irc-network-chooser-dialog:

 - Attach dialog to parent window
   This avoid losing the window and the window order.
Comment 1 Michael Wood 2012-11-01 17:28:24 UTC 
Created attachment 227830 [details] [review]
Make sure the port GtkSpinButton gets enough space
Comment 2 Michael Wood 2012-11-01 17:28:57 UTC 
Created attachment 227831 [details] [review]
Don't allow window resizing
Comment 3 Guillaume Desmottes 2012-11-02 09:29:58 UTC 
Review of attachment 227829 [details] [review]:

This patch introduces a warning, I'll fix it when merging.

::: libempathy-gtk/empathy-irc-network-chooser-dialog.c
@@ +304,3 @@
   GtkWidget *dialog;
 
+  dialog = empathy_irc_network_dialog_show (network, self);

empathy-irc-network-chooser-dialog.c: In function 'display_irc_network_dialog':
empathy-irc-network-chooser-dialog.c:306:3: error: passing argument 2 of 'empathy_irc_network_dialog_show' from incompatible pointer type [-Werror]
In file included from empathy-irc-network-chooser-dialog.c:34:0:
empathy-irc-network-dialog.h:30:13: note: expected 'struct GtkWidget *' but argument is of type 'struct EmpathyIrcNetworkChooserDialog *'
Comment 4 Guillaume Desmottes 2012-11-02 09:30:05 UTC 
Review of attachment 227830 [details] [review]:

++
Comment 5 Guillaume Desmottes 2012-11-02 09:30:13 UTC 
Review of attachment 227831 [details] [review]:

++
Comment 6 Guillaume Desmottes 2012-11-02 09:31:00 UTC 
Merged to msater, thanks for the patches!