After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687345 - sidebar too big on 'fi_FI' locale
sidebar too big on 'fi_FI' locale
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: wizard
3.6.x
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks: 686781
 
 
Reported: 2012-11-01 14:54 UTC by Zeeshan Ali
Modified: 2016-03-31 13:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot of the issue (241.41 KB, image/png)
2012-11-01 14:54 UTC, Zeeshan Ali 		  Details
Fix sidebar width in non-english (1.58 KB, patch)
2013-02-22 09:28 UTC, Alexander Larsson 		accepted-commit_now Details | Review

Description Zeeshan Ali 2012-11-01 14:54:20 UTC 
Created attachment 227805 [details]
Screenshot of the issue

The attached screenshot shows the problem. Launched boxes as: LANG=fi_FI.utf8 gnome-boxes PATH_TO_WIN7_ISO
Comment 1 Alexander Larsson 2013-02-22 09:16:02 UTC 
I believe this is caused by the minigraphs
CPU: ____ I/O: ____ Net: _____
becomes
Suoritin: ____ I/O:      _____ Verkoo:  ____

Which has two problems:
1) The labels enforce the same width
2) Some of the labels are much longer
Comment 2 Alexander Larsson 2013-02-22 09:17:45 UTC 
Oh. Interestng.
Actually its even worse, as the code forces the graphs themselves to be the same size as the labels.
Comment 3 Alexander Larsson 2013-02-22 09:28:27 UTC 
Created attachment 237153 [details] [review]
Fix sidebar width in non-english

Some languages use wider strings for some of the minigraph
labels in the sidebar, so we can't force these labels to be
the same size, nor can we rely on the label width to pick
the minigraph width.
Comment 4 Christophe Fergeau 2013-02-22 10:55:08 UTC 
Review of attachment 237153 [details] [review]:

Helps with the French translation as well

::: src/mini-graph.vala
@@ +23,3 @@
         this.points = points;
         this.npoints = npoints;
+        this.set_size_request (32, -1);

Why the 32 ?
Comment 5 Alexander Larsson 2013-02-22 11:40:47 UTC 
Review of attachment 237153 [details] [review]:

::: src/mini-graph.vala
@@ +23,3 @@
         this.points = points;
         this.npoints = npoints;
+        this.set_size_request (32, -1);

It makes them about the size as in the mockups.
Comment 6 Christophe Fergeau 2013-02-28 09:23:00 UTC 
Review of attachment 237153 [details] [review]:

ACK
Comment 7 Alexander Larsson 2013-02-28 09:26:38 UTC 
pushed