After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687323 - e-contact-map breaks with API change on geocode-glib side
e-contact-map breaks with API change on geocode-glib side
Status: RESOLVED OBSOLETE
Product: jhbuild
Classification: Infrastructure
Component: module sets
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2012-11-01 07:50 UTC by Alban Browaeys
Modified: 2014-03-12 13:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
update for new geocode-glib api (828 bytes, patch)
2012-11-01 07:50 UTC, Alban Browaeys
none Details | Review
use geocode-glib 0.99.0 for jhbuild (811 bytes, patch)
2012-12-12 13:31 UTC, Alban Browaeys
none Details | Review

Description Alban Browaeys 2012-11-01 07:50:11 UTC
Created attachment 227780 [details] [review]
update for new geocode-glib api

Here is a patch that replace removed geocode-glib geocode_object_new with g_object_new call as is done in geocode-glib itself.
Comment 1 André Klapper 2012-11-01 10:10:16 UTC
With which geocode-glib version does this start?
Comment 2 Matthew Barnes 2012-11-01 11:14:29 UTC
There is no release with these changes yet.

Bastien said he's reworking the API, so presumably more changes are coming.  I think for the moment it would be better to lock into version 0.99.0 than try to chase unreleased API changes.

Unfortunately geocode-glib's configure.ac still reports the version a 0.99.0, but I'll see if I can get Bastien to bump it forward so we can distinguish released versus unreleased changes.
Comment 3 Alban Browaeys 2012-11-05 16:43:35 UTC
Cannot tell the version right now , I am using jhbuild which pull master
the commit is :
088f31d6c2eab04a2db871d7da2a665b322a9884 lib: Remove geocode_object_new() from the public API

I bet I should reassign the bug to the gnome jhbuild moduleset for it to pull from a predefined version of geocode-glib ?
Comment 4 Matthew Barnes 2012-11-05 17:14:27 UTC
(In reply to comment #3)
> I bet I should reassign the bug to the gnome jhbuild moduleset for it to pull
> from a predefined version of geocode-glib ?

Yes, that or else temporarily add --disable-contact-maps to evolution's configure command, which avoids the geocode-glib dependency altogether.

Bastien gave me permission to bump the geocode-glib version number in git to 0.99.1, so I'm restricting Evolution's dependency to = 0.99.0 until the next geocode-glib release.

http://git.gnome.org/browse/evolution/commit/?id=97115e6e0d136b1f47f55d171760927f23ab3b5d

I'll leave this open for you to reassign to jhbuild.
Comment 5 Alban Browaeys 2012-12-12 13:31:59 UTC
Created attachment 231365 [details] [review]
use geocode-glib 0.99.0 for jhbuild
Comment 6 Matthew Barnes 2012-12-12 14:29:02 UTC
Bastien already supplied a patch for newer geocode-glib API, but I'm holding off until I see a new geocode-glib tarball release.

*** This bug has been marked as a duplicate of bug 689055 ***
Comment 7 Matthew Barnes 2012-12-12 14:30:13 UTC
Oh my bad, I didn't look at the patch close enough.  Thought it was for Evolution.  Sorry about that.
Comment 8 Javier Jardón (IRC: jjardon) 2014-03-12 13:06:34 UTC
Hello Alban,

This only affects 3.8 and seems to be resolved in 3.10 and 1.12 modulesets, so Im going to close this as obsolete. Thanks for the bug report!