After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687310 - dconf-editor should install a highcontrast app icon
dconf-editor should install a highcontrast app icon
Status: RESOLVED FIXED
Product: dconf-editor
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: dconf-editor maintainer(s)
dconf-editor maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-11-01 01:47 UTC by Matthias Clasen
Modified: 2015-02-22 12:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
a collection of dconf-editor icons (49.33 KB, image/svg+xml)
2012-12-01 13:45 UTC, yuki
  Details
magnifying glass icon from the symbolic theme (4.73 KB, image/svg+xml)
2012-12-02 00:09 UTC, Meg Ford
  Details
checkmark icon from gnome icon theme symbolic (3.71 KB, image/svg+xml)
2012-12-02 00:12 UTC, Meg Ford
  Details
dconf-editor icon 1 (18.71 KB, image/svg+xml)
2012-12-02 11:23 UTC, yuki
  Details
dconf-editor icon2 (4.18 KB, image/svg+xml)
2012-12-02 11:24 UTC, yuki
  Details
dconf-editor icon (18.84 KB, image/svg+xml)
2013-01-09 06:59 UTC, yuki
  Details
16x16 highcontrast rendering (553 bytes, image/png)
2013-01-12 20:19 UTC, Matthias Clasen
  Details
22x22 highcontrast rendering (845 bytes, image/png)
2013-01-12 20:20 UTC, Matthias Clasen
  Details
24x24 highcontrast rendering (1010 bytes, image/png)
2013-01-12 20:20 UTC, Matthias Clasen
  Details
32x32 highcontrast rendering (1.30 KB, image/png)
2013-01-12 20:21 UTC, Matthias Clasen
  Details
48x48 highcontrast rendering (1.97 KB, image/png)
2013-01-12 20:21 UTC, Matthias Clasen
  Details
256x256 highcontrast rendering (12.04 KB, image/png)
2013-01-12 20:22 UTC, Matthias Clasen
  Details
editor: add new high contrast icons (26.18 KB, patch)
2013-01-24 16:35 UTC, Allison Karlitskaya (desrt)
none Details | Review

Description Matthias Clasen 2012-11-01 01:47:18 UTC
We are aiming to have an highcontrast app icon for all apps in 3.8.
See https://live.gnome.org/GnomeGoals/HighContrastAppIcons
Comment 1 yuki 2012-12-01 13:45:36 UTC
Created attachment 230377 [details]
a collection of dconf-editor icons

i did some designs on the dconf icon . if one of the icons suit the theme please pick one of the icon. feel free to give me advice on how to improve the icon and where i should improve on.
Comment 2 Allison Karlitskaya (desrt) 2012-12-01 16:06:23 UTC
I'm rather fond of them all.  Thanks!

I'm not sure what is required in terms of proper outlines (in order to be seen well against light and dark backgrounds).  I'm cc:ing Meg, who can hopefully help.
Comment 3 Meg Ford 2012-12-02 00:09:10 UTC
Created attachment 230422 [details]
magnifying glass icon from the symbolic theme
Comment 4 Meg Ford 2012-12-02 00:12:44 UTC
Created attachment 230423 [details]
checkmark icon from gnome icon theme symbolic
Comment 5 Meg Ford 2012-12-02 00:25:25 UTC
Hi Yuki!
These look nice! I think that the first icon would make the best version for high contrast. To make a high contrast icon, you need to make the icon fit into a 16x16 px square. Make a square and set both the stroke and the paint of the square to undefined. The minimum size for each shape or stoke you use in your icon should be 1 px. Be sure to leave a 1 px space between the checkmark and the magnifying glass so there is a clear difference between your shapes. Your magnifying glass and checkmark shapes need do be made with either stroke or fill, not both (you can check this by pressing Shift+Ctrl+F in Inkscape and looking in the stroke/fill editor that pops up). The RBG color of your icon should be 190, 190, 190, 255. You don't need to worry about outlines, since Cosimo Cecchi wrote a script that generates them automatically. If you have questions, feel free to comment on the bug or ask on #gnome-design on irc. I am not on very much, but jimmac and lapo would be happy to help you :) I'm attaching a magnifing glass icon and a checkmark icon from the theme so you can look at them fr reference. The complete theme is here: http://git.gnome.org/browse/gnome-icon-theme-symbolic/. You can look at it if you know how to use git, but if you don't know how to use git then don't worry.Thanks for working on this!
-Meg
Comment 6 yuki 2012-12-02 11:23:37 UTC
Created attachment 230436 [details]
dconf-editor icon 1

feel free to comment
Comment 7 yuki 2012-12-02 11:24:41 UTC
Created attachment 230437 [details]
dconf-editor icon2
Comment 8 Meg Ford 2012-12-02 17:43:17 UTC
Hi, these look really good! I have a few more comments:
    The inner and outer edges of your circle need to align exactly with the grid (press # to view it in Inkscape). Please make filled part of the circle 2 px wide if possible, it is easier to see than 1 px (1 px is the minimum). 
    The end of the handle of the magnifying glass should probably be rounded like the handle in the example, so it fits into the theme better. Align to the grid the handle to the grid (you can look at the example to see what I mean).
    checkmark: make it fit exactly in the grid (try to make it whole px size, no .4 px, and align to the grid).
    In the second icon there is some space between the handle and the circle. I really like having the checkmark inside a square, but please make the checkmark sit at least 1 px from the outer edge of the square -- on the bottom you are not showing enough of the square.

  Once you are done, there are some weird things you need to do in order to have the icon work properly. you need to put a 16x16 px square with the fill and stroke unset into your icon. then you need to select all of your shapes and make them into one group (if any of the shapes you are using are already a group, ungroup them and re-group as one group with the square). Then right click on your group and choose "object properties". Set the title of your icon to the name (I guess dconf-editor). This is because the icon will go in a sheet with a lot of other icons. There is a ruby script that crawls the sheet looking for 16x 16 px squares and crops them out to make the icons. (The square is gone in the examples I attached because the script removed them when it cut them out of the big svg sheet).
Comment 9 Meg Ford 2012-12-02 22:18:30 UTC
I meant *align the handle to the grid* sorry!
Comment 10 Allison Karlitskaya (desrt) 2012-12-02 23:33:31 UTC
fwiw, I prefer "icon 1" (the one with the square)
Comment 11 Meg Ford 2012-12-03 00:16:13 UTC
Are you planning to ship it with the app or rely on g-t-s to install it, Ryan?
Comment 12 Allison Karlitskaya (desrt) 2012-12-03 02:05:15 UTC
I guess it makes more sense with the app?  I install my 'normal' icon that way...

Is there documentation for what I need to do to install it properly?
Comment 13 Meg Ford 2012-12-03 02:12:09 UTC
I'm not sure how the outlining will work if you install it with the app. I'm cc'ing Jakub since I see that he recommended shipping with the app on https://bugzilla.gnome.org/show_bug.cgi?id=687306
Comment 14 Matthias Clasen 2012-12-03 03:59:26 UTC
Yes, we're aiming for shipping app icons with the app. As for whats required, look at what I've done in gnome-system-log

http://git.gnome.org/browse/gnome-system-log/commit/?id=878bcf652c5d1622ea5e226b51589172038d0710
Comment 15 Meg Ford 2012-12-03 05:16:05 UTC
So is 16x16 svg the only thing the apps need to provide (I can't tell because you are reusing the g-t-s pngs for gnome-system-log), and does the app icon need a 1px outline, black color, etc?
Comment 16 yuki 2012-12-03 08:16:40 UTC
i will work on the one with the square
Comment 17 Meg Ford 2012-12-03 14:43:13 UTC
OK, sounds good yuki, thanks! You don't need to add the 16x16 px square or set the name in "object properties" since the icon is going to be shipped with the app.
Comment 18 Jakub Steiner 2012-12-03 15:07:03 UTC
The grouping and naming of the object group is indeed only sued for "export" of teh whole gnome-icon-theme-symbolic sheet into the individual -symbolic icons. If the app will be shipping a single app icon, just make sure your objects on the 16x16px canvas only have either a stroke or a fill, not both for the recoloring to work (for the current two stroke HC script and future runtime recoloring).


P.S.: I find the use of the loupe metaphor for dconf-editor pretty bad, and a little ironic as it doesn't seem to provide search functionality.
Comment 19 Meg Ford 2012-12-03 15:10:59 UTC
Then you should suggest a new metaphor so yuki isn't wasting time, Jakub. IMO it's fine to say something isn't a proper metaphor, but suggesting an alternative would be more constructive, especially if you are critiquing a newcomer.
Comment 20 Jakub Steiner 2012-12-03 18:07:01 UTC
Oh sorry for rubbing you the wrong way. I'm not criticizing yuki as dconf has been using that metaphor for the fullcolor variant and it made sense to stick to an existing one. 

A fusebox, or just a bunch of microswitches would do. For the symbol that would get simplified to 2 or 3.
Comment 21 Jakub Steiner 2012-12-03 18:10:32 UTC
Turns out I made a hicolor gconf-editor icon with those switches. I would expect dconf to just carry gconf's torch here. Do we really need these tools to maintain their identity?
Comment 22 Meg Ford 2012-12-03 18:13:42 UTC
You didn't rub me the wrong way, Jakub. I was just suggesting you expand on your comment so yuki knew what you wanted :)
Comment 23 Jakub Steiner 2012-12-03 18:20:10 UTC
The gconf icon I referred to is here - https://raw.github.com/gnome-design-team/gnome-icons/master/apps/src/configuration-editor.svg
Comment 24 Allison Karlitskaya (desrt) 2012-12-03 18:50:10 UTC
I'm reasonably fond of the existing icon and I think it makes sense as a metaphor.  It allows you to inspect your preferences.

Of course, the magnifying glass has a near-universal metaphorical meaning of "search", but in this case it doesn't fall over very hard: dconf-editor really is the best way to search your preferences by name...
Comment 25 Meg Ford 2012-12-03 18:58:18 UTC
Not trying to question authority or anything here, but we use it for edit-find in g-i-t-s, which is pretty close to the meaning here.
Comment 26 Meg Ford 2012-12-03 19:22:33 UTC
Anyway, I'm sure that Jakub can deal with this from here since he maintains g-i-t-s. Un cc'ing myself.
Comment 27 Jakub Steiner 2012-12-03 19:56:39 UTC
I'm just providing a suggestion, it's up to an app author what icon they want to present themselves under. That said, the fullcolor icon isn't really executed well under the present Tango guidelines.
Comment 28 Allison Karlitskaya (desrt) 2013-01-02 19:02:20 UTC
hi yuki,

Any follow up here?
Comment 29 yuki 2013-01-03 16:21:05 UTC
sry i kinda busy but will update once I done .
Comment 30 yuki 2013-01-09 06:59:19 UTC
Created attachment 233041 [details]
dconf-editor icon
Comment 31 Matthias Clasen 2013-01-12 20:19:48 UTC
Created attachment 233329 [details]
16x16 highcontrast rendering
Comment 32 Matthias Clasen 2013-01-12 20:20:14 UTC
Created attachment 233330 [details]
22x22 highcontrast rendering
Comment 33 Matthias Clasen 2013-01-12 20:20:43 UTC
Created attachment 233331 [details]
24x24 highcontrast rendering
Comment 34 Matthias Clasen 2013-01-12 20:21:09 UTC
Created attachment 233332 [details]
32x32 highcontrast rendering
Comment 35 Matthias Clasen 2013-01-12 20:21:41 UTC
Created attachment 233333 [details]
48x48 highcontrast rendering
Comment 36 Matthias Clasen 2013-01-12 20:22:07 UTC
Created attachment 233334 [details]
256x256 highcontrast rendering
Comment 37 Matthias Clasen 2013-01-12 20:23:00 UTC
I figured out how to use the create-highcontrast utility in gnome-themes-standard to create proper highcontrast renderings of this icon.

This is what we should install.
Comment 38 Allison Karlitskaya (desrt) 2013-01-24 16:27:46 UTC
yuki: do you have a name that you prefer be written in the commit log (since you are the author)?
Comment 39 Allison Karlitskaya (desrt) 2013-01-24 16:35:50 UTC
Created attachment 234313 [details] [review]
editor: add new high contrast icons
Comment 40 yuki 2013-01-28 14:24:16 UTC
just name it as dconf-editor .
Comment 41 Allison Karlitskaya (desrt) 2013-02-11 19:31:54 UTC
Included in the 0.15.3 release just made.  Thanks!
Comment 42 André Klapper 2015-02-22 12:22:41 UTC
[moving dconf>editor tickets to dconf-editor product. See bug 744791]