After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687287 - gnome-shell-perf-tool: Fix various problems
gnome-shell-perf-tool: Fix various problems
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-31 19:33 UTC by Owen Taylor
Modified: 2012-11-05 18:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-shell-perf-tool: Fix various problems (4.79 KB, patch)
2012-10-31 19:33 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2012-10-31 19:33:09 UTC 
This seems to get gnome-shell-perf-tool working for me - I've tested both
locally and with an upload to shell-perf.gnome.org.
Comment 1 Owen Taylor 2012-10-31 19:33:12 UTC 
Created attachment 227754 [details] [review]
gnome-shell-perf-tool: Fix various problems

* Fix wrong parameter name to on_name_appeared callbacks
* optparse doesn't just leave extra command line arguments, it
  errors out, so don't try to pass through extra arguments -
  instead add explicit passthrough for '--replace'
* Fix usage of Gio.DBusProxy
* Add a default value for --perf so that if it's not supplied
  things don't die with a mysterious error message. (This wasn't
  needed when --perf enabled perf-mode)
Comment 2 drago01 2012-11-05 07:12:30 UTC 
Review of attachment 227754 [details] [review]:

Looks good; did test running it locally here seems to work fine.
Comment 3 Owen Taylor 2012-11-05 18:09:08 UTC 
Attachment 227754 [details] pushed as a21ddb5 - gnome-shell-perf-tool: Fix various problems