After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687243 - ODF creates unnecessarily large files
ODF creates unnecessarily large files
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: import/export OOo / OASIS
git master
Other Linux
: Normal normal
: ---
Assigned To: Andreas J. Guelzow
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2012-10-31 03:08 UTC by Andreas J. Guelzow
Modified: 2012-11-03 16:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sample gnumeric file (1.77 KB, application/x-gnumeric)
2012-10-31 03:08 UTC, Andreas J. Guelzow 		  Details
Tentative patch (7.49 KB, patch)
2012-11-03 16:08 UTC, Morten Welinder 		committed Details | Review

Description Andreas J. Guelzow 2012-10-31 03:08:40 UTC 
Created attachment 227700 [details]
sample gnumeric file

Saving the attached file to ODF creates an unnecessarily large file since there is a large number of rows that should be collapsed as repeated rows.

Note that 1.10.17 created a much smaller file since it correctly collapsed the rows. It seems that trusting odf_write_content_rows to be efficient on styled empty rows was ill advised.
Comment 1 Morten Welinder 2012-11-03 16:08:41 UTC 
Created attachment 227967 [details] [review]
Tentative patch

This fixes the repeated-row problems and provides a decent speedup for
sheets with lots of cells.

(ssh firewalled here, so no commit access)
Comment 2 Andreas J. Guelzow 2012-11-03 16:29:55 UTC 
Comment on attachment 227967 [details] [review]
Tentative patch

loks good, committed
Comment 3 Andreas J. Guelzow 2012-11-03 16:30:46 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.