After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687242 - keyboard: simplify using Caribou.KeyModel.label
keyboard: simplify using Caribou.KeyModel.label
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: keyboard
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-31 01:57 UTC by Daiki Ueno
Modified: 2012-11-02 23:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
keyboard: simplify using Caribou.KeyModel.label (1.88 KB, patch)
2012-10-31 01:57 UTC, Daiki Ueno
committed Details | Review

Description Daiki Ueno 2012-10-31 01:57:32 UTC
Now that libcaribou has Caribou.KeyModel.label (bug 656175), the code copied from Antler is not needed.
Comment 1 Daiki Ueno 2012-10-31 01:57:35 UTC
Created attachment 227697 [details] [review]
keyboard: simplify using Caribou.KeyModel.label
Comment 2 Giovanni Campagna 2012-11-02 15:31:30 UTC
Review of attachment 227697 [details] [review]:

Tested, works fine.
Comment 3 Daiki Ueno 2012-11-02 23:59:46 UTC
Thanks for the review.

Attachment 227697 [details] pushed as dd9fc91 - keyboard: simplify using Caribou.KeyModel.label