After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687229 - Embed ESourceSelector widget from libedataserverui
Embed ESourceSelector widget from libedataserverui
Status: RESOLVED FIXED
Product: almanah
Classification: Other
Component: General
0.10.x
Other Linux
: Normal normal
: ---
Assigned To: diary-maint
diary-maint
Depends on:
Blocks: 686688
 
 
Reported: 2012-10-30 22:01 UTC by Matthew Barnes
Modified: 2012-12-13 14:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (72.51 KB, patch)
2012-10-30 22:01 UTC, Matthew Barnes 		committed Details | Review

Description Matthew Barnes 2012-10-30 22:01:14 UTC 
Created attachment 227688 [details] [review]
Proposed patch

Besides Evolution itself, Almanah is the only remaining software package with a (legitimate) dependency on libedataserverui, namely for the ESourceSelector widget.

For GNOME 3.8, I would like to withdraw libedataserverui as a reusable shared library and absorb the useful bits back into Evolution where I can make some necessary changes and enhancements without being limited by backward-compatibility constraints.  This would also let us remove the GTK+ build requirement from Evolution-Data-Server.

I'd suggest embedding a copy of e-source-selector.[ch] in the Almanah source code, where you can periodically refresh it from Evolution if you wish.  Patch to do so is attached.
Comment 1 Álvaro Peña 2012-11-01 19:11:42 UTC 
Review of attachment 227688 [details] [review]:

Ok.
Comment 2 Álvaro Peña 2012-11-01 19:14:01 UTC 
(In reply to comment #0)
> Created an attachment (id=227688) [details] [review]
> Proposed patch
> 
> Besides Evolution itself, Almanah is the only remaining software package with a
> (legitimate) dependency on libedataserverui, namely for the ESourceSelector
> widget.
> 
> For GNOME 3.8, I would like to withdraw libedataserverui as a reusable shared
> library and absorb the useful bits back into Evolution where I can make some
> necessary changes and enhancements without being limited by
> backward-compatibility constraints.  This would also let us remove the GTK+
> build requirement from Evolution-Data-Server.
> 
> I'd suggest embedding a copy of e-source-selector.[ch] in the Almanah source
> code, where you can periodically refresh it from Evolution if you wish.  Patch
> to do so is attached.

Ok Matthew. Looks fine to me. Thanks for the patch!
Comment 3 Matthew Barnes 2012-12-13 14:41:02 UTC 
Wasn't sure if this was waiting on _me_ to commit.  I removed libedataserverui from E-D-S yesterday, so I've gone ahead and committed this to avoid a build break.

http://git.gnome.org/browse/almanah/commit/?id=e481f5abdb46d41ac00ee3393332e92f605b55e7