After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687189 - Drop unnecessary libedataserverui dependency
Drop unnecessary libedataserverui dependency
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: calendar
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: 686688
 
 
Reported: 2012-10-30 12:04 UTC by Matthew Barnes
Modified: 2012-11-08 09:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (3.95 KB, patch)
2012-10-30 12:04 UTC, Matthew Barnes 		committed Details | Review

Description Matthew Barnes 2012-10-30 12:04:05 UTC 
Created attachment 227628 [details] [review]
Proposed patch

Prior to 3.6.0, gnome-shell linked to libedataserverui to use the old E-D-S password API.

As of 3.6.0, E-D-S now centralizes authentication prompts so client applications don't have to display their own.  But in bug 677402 I forgot to remove the libedataserverui dependency, and also trade the GTK+ main loop for a plain GMainLoop in gnome-shell-calendar-server.c.

My true motivation here is I'd like to absorb libedataserverui back into Evolution, since Evolution is very nearly the only thing actually using it and I'd like to make enhancements to some of those widgets without worrying about API stability.  So I'm auditing modules that still depend on it.

Attached patch applies to both master and gnome-3-6 branches.
Comment 1 Giovanni Campagna 2012-10-30 14:48:10 UTC 
Review of attachment 227628 [details] [review]:

Looks ok to me.