After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687188 - focus changes when resizing a sheet
focus changes when resizing a sheet
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2012-10-30 11:37 UTC by Frédéric Parrenin
Modified: 2012-11-05 19:55 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Frédéric Parrenin 2012-10-30 11:37:05 UTC
- open a new workbook
- go to sheet3
- resize sheet3
- click OK
=> the focus is now on sheet1
Comment 1 Jean Bréfort 2012-10-31 06:28:15 UTC
That might be because all sheets are resized.
Comment 2 Jean Bréfort 2012-11-04 07:44:10 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 3 Andreas J. Guelzow 2012-11-05 15:21:01 UTC
The problem with the committed fix is that it only applies to the initial resizing. The focus changes unexpectantly on undo and redo of this action.
Comment 4 Jean Bréfort 2012-11-05 15:28:00 UTC
My bad.
Comment 5 Andreas J. Guelzow 2012-11-05 15:56:44 UTC
I know how to fix this (at least I think I do) and will do so tonight.
Comment 6 Jean Bréfort 2012-11-05 16:39:15 UTC
The issues comes from update_after_action(), and this does not seem easy to fix. Restoring the sheet from cmd_resize_sheet_undo/redo does not work. We probably need an idle call.
Comment 7 Andreas J. Guelzow 2012-11-05 17:12:44 UTC
I think there is a much simpler solution, we just need to pass the sheets in the correct ordering.
Comment 8 Jean Bréfort 2012-11-05 17:29:31 UTC
You are right, really fixed now.
Comment 9 Andreas J. Guelzow 2012-11-05 19:55:46 UTC
I have just fixed a related issue, namely:

make sure Sheet1 and Sheet2 have different sizes.
select Sheet2
resize this Sheet to its current size applying the change to all sheets.

before my commit the focus would change to Sheet1 (since Sheet2 would not end up in the list of sheets to adjust).