After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687166 - Port to libgee 0.8
Port to libgee 0.8
Status: RESOLVED FIXED
Product: caribou
Classification: Applications
Component: default
git master
Other Linux
: Normal normal
: ---
Assigned To: caribou-maint
caribou-maint
Depends on:
Blocks: 687165
 
 
Reported: 2012-10-30 03:39 UTC by Javier Jardón (IRC: jjardon)
Modified: 2012-11-02 09:16 UTC
See Also:
GNOME target: 3.8
GNOME version: 3.7/3.8

Attachments
Port from libgee 0.6 to 0.8 (2.33 KB, patch)
2012-10-30 19:48 UTC, Daiki Ueno 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2012-10-30 03:39:01 UTC 
libgee 0.8 is the target version for GNOME 3.8
Comment 1 Daiki Ueno 2012-10-30 19:48:42 UTC 
Created attachment 227678 [details] [review]
Port from libgee 0.6 to 0.8

The only change needed is to fix arguments to HashMap constructor.
libgee 0.8 infers hash_func/equal_func from the types.
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-10-31 15:31:39 UTC 
Review of attachment 227678 [details] [review]:

Looks good to me

::: configure.ac
@@ -47,3 @@
   libxklavier,
   libxml-2.0,
-  gee-1.0,

Hmm, curious, so although caribou was only supporting libglee-0.6 it was asking for libglee-1.0?
Comment 3 Daiki Ueno 2012-11-01 01:03:10 UTC 
(In reply to comment #2)

> Hmm, curious, so although caribou was only supporting libglee-0.6 it was asking
> for libglee-1.0?

It was correct.  libgee changed its pkg-config/vapi naming scheme since 0.8 to reflect actual API version instead of 1.0.
Comment 4 Daiki Ueno 2012-11-01 03:37:26 UTC 
Comment on attachment 227678 [details] [review]
Port from libgee 0.6 to 0.8

Thanks, pushed.

Attachment 227678 [details] pushed as f2151eb - Port from libgee 0.6 to 0.8
Comment 5 Rui Matos 2012-11-02 09:16:21 UTC 
I think this should be closed?