After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687132 - Misc fixes for the login dialogs
Misc fixes for the login dialogs
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
: 688008 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-10-29 16:45 UTC by Giovanni Campagna
Modified: 2012-11-09 19:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
LoginDialog: clear previous auth failed messages when trying again (2.55 KB, patch)
2012-10-29 16:46 UTC, Giovanni Campagna 		committed Details | Review
ShellUserVerifier: fix fail counter (1.20 KB, patch)
2012-10-29 16:46 UTC, Giovanni Campagna 		committed Details | Review
UnlockDialog: clear the password on failure (888 bytes, patch)
2012-10-29 16:46 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-10-29 16:45:48 UTC 
Stuff I found while testing bug 687110
Comment 1 Giovanni Campagna 2012-10-29 16:46:09 UTC 
Created attachment 227557 [details] [review]
LoginDialog: clear previous auth failed messages when trying again

When the user has the entered the password for the second time
and clicked OK, clear messages from the previous attempt, so any
new failure is shown clearly.
Comment 2 Giovanni Campagna 2012-10-29 16:46:18 UTC 
Created attachment 227558 [details] [review]
ShellUserVerifier: fix fail counter

If it is updated after checking, it counts the number of failures
not including the current one, so it allows one extra attempt. Instead,
by updating it before checking, we get the expected result of dropping the
curtain at the third password.
Comment 3 Giovanni Campagna 2012-10-29 16:46:26 UTC 
Created attachment 227559 [details] [review]
UnlockDialog: clear the password on failure

It is wrong, and the user can't correct it because it's obfuscated.
Just let him type it again.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-10-29 16:48:34 UTC 
Review of attachment 227558 [details] [review]:

Sure.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-10-29 16:48:48 UTC 
Review of attachment 227559 [details] [review]:

Sure.
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-10-29 16:49:16 UTC 
Review of attachment 227557 [details] [review]:

Makes sense.
Comment 7 Giovanni Campagna 2012-10-29 16:55:19 UTC 
Attachment 227557 [details] pushed as 04debd1 - LoginDialog: clear previous auth failed messages when trying again
Attachment 227558 [details] pushed as b9463d2 - ShellUserVerifier: fix fail counter
Attachment 227559 [details] pushed as a0470bf - UnlockDialog: clear the password on failure

Which ones are to be backported to gnome-3-6?
Comment 8 Ray Strode [halfline] 2012-11-09 19:34:27 UTC 
*** Bug 688008 has been marked as a duplicate of this bug. ***