After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687072 - Remove calls to g_type_init(), bump GLib required version
Remove calls to g_type_init(), bump GLib required version
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-28 22:19 UTC by Colin Walters
Modified: 2012-10-29 15:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove calls to g_type_init(), bump GLib required version (5.69 KB, patch)
2012-10-28 22:19 UTC, Colin Walters
needs-work Details | Review
configure: Unify glib-2.0 and gio-2.0 requirements (1.21 KB, patch)
2012-10-29 15:44 UTC, Colin Walters
committed Details | Review
Remove calls to g_type_init(), bump GLib required version (5.14 KB, patch)
2012-10-29 15:45 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2012-10-28 22:19:10 UTC
While we have the patient open, it doesn't make sense to have distinct
glib-2.0 and gio-2.0 required versions, since they come from the same
module.

See http://git.gnome.org/browse/glib/commit/?id=7c42ab23b55c43ab96d0ac2124b550bf1f49c1ec
Comment 1 Colin Walters 2012-10-28 22:19:12 UTC
Created attachment 227490 [details] [review]
Remove calls to g_type_init(), bump GLib required version
Comment 2 Bastien Nocera 2012-10-29 09:34:30 UTC
Split out the 2 changes and you can remove the "While we have the patient open" lark. I'm not sure what it's supposed to be, but it's not funny.
Comment 3 Colin Walters 2012-10-29 15:44:59 UTC
Created attachment 227548 [details] [review]
configure: Unify glib-2.0 and gio-2.0 requirements

It doesn't make sense to have distinct glib-2.0 and gio-2.0 required
versions, since they come from the same module.
Comment 4 Colin Walters 2012-10-29 15:45:28 UTC
Created attachment 227549 [details] [review]
Remove calls to g_type_init(), bump GLib required version

See http://git.gnome.org/browse/glib/commit/?id=7c42ab23b55c43ab96d0ac2124b550bf1f49c1ec
Comment 5 Bastien Nocera 2012-10-29 15:47:40 UTC
Review of attachment 227548 [details] [review]:

++
Comment 6 Bastien Nocera 2012-10-29 15:48:13 UTC
Review of attachment 227549 [details] [review]:

++
Comment 7 Colin Walters 2012-10-29 15:54:38 UTC
Attachment 227548 [details] pushed as 5588d10 - configure: Unify glib-2.0 and gio-2.0 requirements
Attachment 227549 [details] pushed as 1bb7771 - Remove calls to g_type_init(), bump GLib required version