After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687026 - xml: add "text" attribute to key
xml: add "text" attribute to key
Status: RESOLVED FIXED
Product: caribou
Classification: Applications
Component: default
git master
Other All
: Normal normal
: ---
Assigned To: caribou-maint
caribou-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-28 07:44 UTC by Daiki Ueno
Modified: 2012-10-30 05:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
xml: add "text" attribute to key (3.06 KB, patch)
2012-10-28 07:44 UTC, Daiki Ueno 		accepted-commit_now Details | Review
xml: add "text" attribute to key (3.17 KB, patch)
2012-10-30 05:43 UTC, Daiki Ueno 		committed Details | Review
xml: add "text" attribute to key (3.17 KB, patch)
2012-10-30 05:44 UTC, Daiki Ueno 		none Details | Review

Description Daiki Ueno 2012-10-28 07:44:35 UTC 
Most software keyboards support special keys (like ".com") to input
text instead of a character.  Also, some international keyboads have
such a key in the spec.  For example, with Hindi inscript keyboard,
the character on "%" is "ज्ञ" which is actually a composition of three
characters (U+091e, U+094d, and U+091c).

This patch adds "text" attribute to the XML to specify text to be
generated.  To complete this feature, we will probably need to add
KeyModel.label so antler and gnome-shell can render the labels
properly (somewhat related to bug 656175).
Comment 1 Daiki Ueno 2012-10-28 07:44:37 UTC 
Created attachment 227441 [details] [review]
xml: add "text" attribute to key
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-10-29 11:07:56 UTC 
Review of attachment 227441 [details] [review]:

Looks good to me
Comment 3 Daiki Ueno 2012-10-30 05:43:31 UTC 
Created attachment 227612 [details] [review]
xml: add "text" attribute to key

Add a new attribute "text" to the key elements in XML, so that text
producing keys such as ".com" can be implemented.
Comment 4 Daiki Ueno 2012-10-30 05:44:48 UTC 
The following fix has been pushed:
d4c2802 xml: add "text" attribute to key
Comment 5 Daiki Ueno 2012-10-30 05:44:53 UTC 
Created attachment 227613 [details] [review]
xml: add "text" attribute to key

Add a new attribute "text" to the key elements in XML, so that text
producing keys such as ".com" can be implemented.