After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687018 - xadapter: use level3 shift if possible
xadapter: use level3 shift if possible
Status: RESOLVED FIXED
Product: caribou
Classification: Applications
Component: default
git master
Other All
: Normal normal
: ---
Assigned To: caribou-maint
caribou-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-28 01:53 UTC by Daiki Ueno
Modified: 2012-10-30 05:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
xadapter: use level3 shift if possible (3.87 KB, patch)
2012-10-28 01:53 UTC, Daiki Ueno 		committed Details | Review
xadapter: use level3 shift if possible (3.99 KB, patch)
2012-10-30 05:36 UTC, Daiki Ueno 		none Details | Review

Description Daiki Ueno 2012-10-28 01:53:06 UTC 
Even though keysym remapping was fixed (bug 673547), remapping on
each key press is still too expensive.  Probably we should utilize
Level3 shift modifier to produce desired keysym without remapping.
Comment 1 Daiki Ueno 2012-10-28 01:53:10 UTC 
Created attachment 227433 [details] [review]
xadapter: use level3 shift if possible
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-10-29 11:06:12 UTC 
Review of attachment 227433 [details] [review]:

Seems ok to me, but it would be good to add something more meaningful on the commit description (not just 'what' but also a little of 'why')
Comment 3 Daiki Ueno 2012-10-30 05:36:22 UTC 
Thanks, improved the commit message.

The following fix has been pushed:
0e34f29 xadapter: use level3 shift if possible
Comment 4 Daiki Ueno 2012-10-30 05:36:27 UTC 
Created attachment 227611 [details] [review]
xadapter: use level3 shift if possible

Some international keyboards (such as Czech) assign more than two
keysyms to each key.  Use level 3 shift modifier (so called AltGr) to
designate those keysyms and avoid needless keysym remapping.