After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686939 - Properties view doesn't have a heading
Properties view doesn't have a heading
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: properties
3.6.x
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks: 686781
 
 
Reported: 2012-10-26 11:57 UTC by Allan Day
Modified: 2016-03-31 13:57 UTC
See Also:
GNOME target: ---
GNOME version: 3.5/3.6


Attachments
Add header to properties view (2.83 KB, patch)
2013-01-23 11:22 UTC, Alexander Larsson
committed Details | Review

Description Allan Day 2012-10-26 11:57:52 UTC
It's a bit unclear what this view is. A heading would also visually balance the window.

Something like "<box name> - Properties" could be a good title for the view.
Comment 1 Jakub Steiner 2012-10-26 12:52:00 UTC
With that in place, we would probably be better off with a simple back button (no label) and removing the Name [            ] entry, allowing the name to be changed directly in the toolbar title (granted the 'properties') would be visually separate.

I'll mock this up.
Comment 2 Alexander Larsson 2013-01-23 11:22:41 UTC
Created attachment 234177 [details] [review]
Add header to properties view
Comment 3 Alexander Larsson 2013-01-23 11:23:18 UTC
This just adds the title and changes the back button. Can't edit the title in the UI yet, thats a lot more work.
Comment 4 Christophe Fergeau 2013-01-23 12:52:30 UTC
Review of attachment 234177 [details] [review]:

Looks good overall

::: src/properties.vala
@@ +16,3 @@
+    public string title {
+        set {
+            toolbar.set_labels (_("%s - Properties").printf (App.app.current_item.name), null);

A translator comment to indicate %s is a box name would be nice.

@@ +317,3 @@
             populate ();
+            toolbar_label_bind = null;
+            toolbar_label_bind = App.app.current_item.bind_property ("name", this, "title", BindingFlags.SYNC_CREATE);

Do we need both here to trigger some side-effect?
Comment 5 Alexander Larsson 2013-01-23 13:29:30 UTC
Review of attachment 234177 [details] [review]:

::: src/properties.vala
@@ +16,3 @@
+    public string title {
+        set {
+            toolbar.set_labels (_("%s - Properties").printf (App.app.current_item.name), null);

I'll add one

@@ +317,3 @@
             populate ();
+            toolbar_label_bind = null;
+            toolbar_label_bind = App.app.current_item.bind_property ("name", this, "title", BindingFlags.SYNC_CREATE);

No, thats just a leftover for the old if case.
Comment 6 Alexander Larsson 2013-01-23 13:32:47 UTC
Attachment 234177 [details] pushed as 356985a - Add header to properties view
Comment 7 Alexander Larsson 2013-01-23 13:34:22 UTC
Moved the edit-in-title part to bug 692383