After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686929 - Newly created toolbox is too tall and too narrow
Newly created toolbox is too tall and too narrow
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
2.8.2
Other All
: Normal normal
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
: 695097 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-10-26 10:13 UTC by Tim
Modified: 2013-05-06 21:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Tall window. (133.77 KB, image/png)
2012-10-26 10:13 UTC, Tim
Details
Default session rc (1.96 KB, text/plain)
2012-10-26 16:38 UTC, Tim
Details
Broken session id. (1.84 KB, text/plain)
2012-10-26 16:41 UTC, Tim
Details

Description Tim 2012-10-26 10:13:40 UTC
Created attachment 227345 [details]
Tall window.

There is an occasional (but reliable; it happens after I've started and quit gimp a few times) bug on OSX where the toolbox becomes very tall and only one icon wide. I suspect it is actually zero width but clamped to a minimum of one icon (see attached screenshot).

There is no way to resize the window back to normal. Hiding and showing it again has no effect. When you first start the app, or if you tell it not to remember window positions in the preferences and then "reset window positions to defaults" and restart it, the toolbox is the correct size. However there is still no way to resize it.

The only workaround I know is to enable single window mode.

My *guess* as to what causes this bug, is improper handling of saving the window positions on closing the app. It makes sense, and also that code is clearly not great - e.g. you can't close the app from the dashboard (right click->close).

Also, very off-topic but I think your reasoning for using bugzilla is pretty specious. It would *clearly* be preferable to have a registration-free system where you can just enter your email address (like django), or use OAuth2 (like stackoverflow). Having a password for a low-security site that people might only use once is kind of ridiculous. But I imagine the real reasons you stick with it are:

* It's what the rest of Gnome use (as you said; a fair enough reason).
* Nobody likes getting bug reports and we have more than we can manage anyway, so making it *easier* to submit them isn't exactly high on our priorities.
* It was the best at the time, and a good drop-in replacement (probably) doesn't exist so we would rather spend our effort on more interesting things.

Which is fine. But I hate it when people make up dubious technical reasons for decisions that are more about social / workload factors.
Comment 1 Michael Schumacher 2012-10-26 13:51:59 UTC
Tim, are you volunteering to implement and maintain a GIMP-specific bug tracking system (which ties nicely into GNOME bugzilla, because many of the dependencies track bugs there) for the next decade? :)
Comment 2 Tim 2012-10-26 14:49:07 UTC
Haha, like you, I think that would be more effort than it would be worth! Actually now that I think about it, the best and easiest thing to do would be to add OAuth2 to bugzilla itself. Probably wouldn't be that hard (I've done OAuth2 login for my site and it was fairly painless), but apparently bugzilla is written in perl, and it's been a decade since I so much as looked at a line of perl!
Comment 3 Max Mustermann 2012-10-26 14:58:39 UTC
Sorry for chipping in. Is this a GIMP or a Bugzilla bug? Please stick with the topic or discuss your ideas in the appropriate mailing list. Thank you.
Comment 4 Michael Natterer 2012-10-26 16:23:35 UTC
Can you attach your sessiorc please? It's in Library/GIMP/2.8
Comment 5 Tim 2012-10-26 16:38:37 UTC
Created attachment 227374 [details]
Default session rc
Comment 6 Tim 2012-10-26 16:40:11 UTC
Yes, I've found out more info as well: the bug can be reliably triggered by clicking the X of the toolbox, and then going to Windows->New Toolbox. You can reliably fix it by enabling and disabling Single Window Mode.

Here is the default sessionrc bit for the toolbox:

(session-info "toplevel"
    (factory-entry "gimp-toolbox-window")
    (position 54 22)
    (size 168 756)
    (open-on-exit)
    (gimp-toolbox
        (book
            (current-page 0)
            (dockable "gimp-tool-options"
                (tab-style automatic)))))

And after closing it with the X, that section is removed, and then after "New Toolbox":

(session-info "toplevel"
    (factory-entry "gimp-toolbox-window")
    (position 627 22)
    (size 56 1162)
    (open-on-exit)
    (gimp-toolbox))

I attached full files.

PS: Did I mention bugzilla is not so great? Clicking "Add an attachment" wipes the comment you just wrote!
Comment 7 Tim 2012-10-26 16:41:05 UTC
Created attachment 227375 [details]
Broken session id.
Comment 8 Michael Natterer 2012-10-26 17:37:25 UTC
I don't follow. Originally you said this happens by just quitting and
starting gimp a few times, now you close the toolbox and open a new
one from the menu. Which one triggers the problem :)
Comment 9 Tim 2012-10-26 17:54:23 UTC
Yeah I was wrong about that. Just closing/opening the menu causes the problem.
Comment 10 Michael Schumacher 2012-10-26 18:08:29 UTC
What menu?
Comment 11 Tim 2012-10-26 18:09:50 UTC
Sorry; toolbox, not menu.
Comment 12 Michael Natterer 2012-10-29 00:29:29 UTC
Ok I can reproduce this, a newly created toolbox opens tall any narrow,
clearly broken.
Comment 13 Michael Natterer 2012-10-29 00:37:50 UTC
Happens on all platforms, actually.
Comment 14 Michael Natterer 2013-01-17 18:40:53 UTC
Fixed in master and gimp-2-8, the toolbox defaults to two columns now:

commit 6dcd7c425e3283f6c4d0549981c6f11126198b84
Author: Michael Natterer <mitch@gimp.org>
Date:   Thu Jan 17 19:37:03 2013 +0100

    Bug 686929 - Newly created toolbox is too tall and too narrow
    
    Set the dock window's geometry hints after the tool palette's style is
    known, not after the toolbox' style is known, so we get the right tool
    button dimensions for minimum size and size increments.
    (cherry picked from commit 7e273bc6d0d51300c2fafca355c729170689f2ca)

 app/widgets/gimptoolbox.c     |   15 ---------------
 app/widgets/gimptoolpalette.c |    2 ++
 2 files changed, 2 insertions(+), 15 deletions(-)
Comment 15 Michael Schumacher 2013-03-04 09:47:54 UTC
*** Bug 695097 has been marked as a duplicate of this bug. ***
Comment 16 Barry Jackson 2013-05-06 21:25:49 UTC
IMHO 4 columns would be a more sensible default.
Why is the setting not remembered between instances of the toolbox?
If i set it to 4 columns, close it and use CTRL/b to open another it opens at 2 columns.