After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686921 - Remove some of the repetition from gio/tests/Makefile.am
Remove some of the repetition from gio/tests/Makefile.am
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-10-26 08:44 UTC by Stef Walter
Modified: 2012-10-26 19:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gio: Remove LDADD repetition from gio/tests Makefile (14.04 KB, patch)
2012-10-26 08:44 UTC, Stef Walter 		none Details | Review
gio: Remove LDADD repetition from gio/tests Makefile (14.23 KB, patch)
2012-10-26 09:14 UTC, Stef Walter 		committed Details | Review
gio: No need to specify SOURCES when name matches executable (7.01 KB, patch)
2012-10-26 09:14 UTC, Stef Walter 		committed Details | Review

Description Stef Walter 2012-10-26 08:44:01 UTC 
Remove some of the needless repetition noise in Makefile.am
Comment 1 Stef Walter 2012-10-26 08:44:06 UTC 
Created attachment 227335 [details] [review]
gio: Remove LDADD repetition from gio/tests Makefile

Using a global LDADD for the basic libraries to link.
Comment 2 Stef Walter 2012-10-26 09:14:07 UTC 
Created attachment 227338 [details] [review]
gio: Remove LDADD repetition from gio/tests Makefile

Using a global LDADD for the basic libraries to link.
Comment 3 Stef Walter 2012-10-26 09:14:15 UTC 
Created attachment 227339 [details] [review]
gio: No need to specify SOURCES when name matches executable

Removes some of the duplication from Makefile.am
Comment 4 Colin Walters 2012-10-26 14:04:55 UTC 
Review of attachment 227338 [details] [review]:

Yeah, looks fine.  Using global automake variables makes it harder to convert to non-recursive automake, so I typically dislike it, but on the other hand, there are a rather extreme number of executables here.
Comment 5 Colin Walters 2012-10-26 14:05:37 UTC 
Review of attachment 227339 [details] [review]:

I didn't know that actually.  Nice.