After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686898 - g_unix_signal_source_new: Allow SIGUSR1 and SIGUSR2
g_unix_signal_source_new: Allow SIGUSR1 and SIGUSR2
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-10-25 22:23 UTC by Colin Walters
Modified: 2012-10-26 13:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
g_unix_signal_source_new: Allow SIGUSR1 and SIGUSR2 (1.65 KB, patch)
2012-10-25 22:23 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2012-10-25 22:23:22 UTC 
These are user defined, it makes sense to allow watching them.  This
is needed to port gnome-session and gdm over.
Comment 1 Colin Walters 2012-10-25 22:23:25 UTC 
Created attachment 227313 [details] [review]
g_unix_signal_source_new: Allow SIGUSR1 and SIGUSR2
Comment 2 Allison Karlitskaya (desrt) 2012-10-26 07:02:24 UTC 
Review of attachment 227313 [details] [review]:

::: glib/glib-unix.c
@@ +184,3 @@
  * signal @signum.  Currently only <literal>SIGHUP</literal>,
+ * <literal>SIGINT</literal>, <literal>SIGTERM</literal>,
+ * <literal>SIGUSR1</literal> and <literal>SIGUSR2</literal> can be

subtle dropping of the oxford comma ;)


but seriously.. i'd prefer "since 2.36 it's also possible to monitor..."


otherwise i'm happy, so just commit after the fix.
Comment 3 Colin Walters 2012-10-26 13:31:02 UTC 
Attachment 227313 [details] pushed as 36bf253 - g_unix_signal_source_new: Allow SIGUSR1 and SIGUSR2