After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686879 - messageTray: Fix close button position in RTL locales (gnome-3-6)
messageTray: Fix close button position in RTL locales (gnome-3-6)
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-25 17:03 UTC by Florian Müllner
Modified: 2012-10-26 10:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
messageTray: Fix close button position in RTL locales (1.14 KB, patch)
2012-10-25 17:03 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2012-10-25 17:03:11 UTC 
The notification close button does not take the text direction into account, so its position ends up wrong in RTL.
This is fixed in master by commit 8c4b34de4ecec0b48, but it would be nice to have this in gnome-3-6 as well - we can't cherry-pick the patch from master though as it depends on a newer libcroco, so this needs a separate review.
Comment 1 Florian Müllner 2012-10-25 17:03:14 UTC 
Created attachment 227292 [details] [review]
messageTray: Fix close button position in RTL locales
Comment 2 Rui Matos 2012-10-26 10:43:08 UTC 
Review of attachment 227292 [details] [review]:

++
Comment 3 Florian Müllner 2012-10-26 10:54:49 UTC 
Attachment 227292 [details] pushed as a598b06 - messageTray: Fix close button position in RTL locales