GNOME Bugzilla – Bug 686855
When closing a notification, the close button lags behind the notification (should rather fade out or simply disappear)
Last modified: 2013-08-06 12:48:22 UTC
When a notification shows up and you close it with the close button, the notification slides down and the close button desperately tries to keep up with it but lacks behind. Not nice. It would look better if it would fade out or just disappear. For the final design for closing notifications see [0], but I don't know if that is still valid. [0] http://www.youtube.com/watch?v=14z4wdgNF9g&feature=player_detailpage#t=44s
Created attachment 227287 [details] [review] MessageTray: fix immediate hiding of destroyed sources Previously the code to hide the boxpointer without animation for destroyed source would check the number of notifications, and activate if it was 0, but because the signal handler was installed before that of notifications, it would run before they were removed from the list, thus always taking the animated path.
I'd prefer to keep animating the notification while hiding the button immediately, see bug 682237 (which already covers this issue).
Bug 682237 covers a slightly different issue (whether or not the source is destroyed after pressing Close). But I'm ok with marking it duplicate, if you want.
This is a different issue, which is the cause of the "empty bubble" when destroying an item from within the tray, as far as I know. It's fairly clear the code is broken anyway, but I think we can just remove it now.
I'm not sure what you mean that the code is broken (it works fine with the patch), or what part you're proposing to remove...
I meant the existing code that you pointed out is broken. Instead of replacing it with a destroyed property, just remove it outright.
Uhm... If I remove that code, I get the empty bubble thing when the source is destroyed. Is that what you want?
(In reply to comment #7) > Uhm... If I remove that code, I get the empty bubble thing when the source is > destroyed. Is that what you want? This should be covered by bug #686888.
Was this fixed by https://bugzilla.gnome.org/show_bug.cgi?id=682237#c29 ?
Yes, this bug is fixed in master.
Reopening, the patch here fixes 689311.
*** Bug 689311 has been marked as a duplicate of this bug. ***
Giovanni, while this patch fixes the glitch for non-persistent notifications; the issue still happens when the icon does not go away. This is how to verify: - Use a program that puts an icon in the notification area(audio player). - Activation the notification on track changes. - Change the track. - Miss the notification on purpose. - Ctrl+M - Click on the icon. - And click on the body of the notification. - Notice how it shrinks awkwardly. - Profit. :)
Reviewed by Jasper St. Pierre at Guadec.