After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686763 - Extensions should be disabled in lock screen
Extensions should be disabled in lock screen
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: lock-screen
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-24 07:13 UTC by Justin
Modified: 2012-10-26 13:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
3.7.1 compatible sample extension (622 bytes, application/x-compressed-tar)
2012-10-26 10:46 UTC, Florian Müllner
  Details
panelMenu: Fix exception when destroying menuless button (899 bytes, patch)
2012-10-26 10:46 UTC, Florian Müllner
committed Details | Review
Session log (5.01 KB, text/x-log)
2012-10-26 11:13 UTC, Justin
  Details

Description Justin 2012-10-24 07:13:40 UTC
There are extensions that add itself to the top panel, like window buttons. Currently these extensions visible and enabled in lock screen. Ideally, these extensions should be disabled while screen is locked.
Comment 1 Florian Müllner 2012-10-24 19:38:52 UTC
That's indeed how it is supposed to work. What version are you using? Is there anything that indicates an error in ~/.xsession-errors or ~/.cache/gdm/session.log?
Comment 2 Justin 2012-10-26 09:44:46 UTC
I am using gnome remix 12.10. Gnome shell 3.6.1
I do not have .xsession-errors file, so I guess thats fine. Session.log also seemed okay to me, if you want it I can paste it here.

But unfortunately I upgraded to the shell 3.7.1 version and none of the extensions are working anymore (even after updating metadata). So how to go about this, may be close the bug and reopen it if I can reproduce it again?
Comment 3 Florian Müllner 2012-10-26 10:46:13 UTC
Created attachment 227347 [details]
3.7.1 compatible sample extension

(In reply to comment #2)
> I do not have .xsession-errors file, so I guess thats fine.

Yes, it's the old location of .cache/gdm/session.log.

> Session.log also seemed okay to me, if you want it I can paste it here.

Maybe that's a good idea - I wrote a quick 3.7.1-compatible extension as test case, and I could actually reproduce the issue due to a shell bug (patch coming). It did show up rather prominently on stderr/session.log though.
Comment 4 Florian Müllner 2012-10-26 10:46:49 UTC
Created attachment 227348 [details] [review]
panelMenu: Fix exception when destroying menuless button

There's explicit API to create PanelMenu.Buttons with no menu, so
guard against this case in destroy().
Comment 5 Justin 2012-10-26 11:13:16 UTC
Created attachment 227349 [details]
Session log

With your extension, I reproduced the bug and see that panelMenu exception in the session.log. Attached those lines for any ref.
Comment 6 Justin 2012-10-26 11:23:34 UTC
.....and the patch is working fine... :)
Comment 7 Florian Müllner 2012-10-26 11:58:28 UTC
(In reply to comment #0)
> There are extensions that add itself to the top panel, like window buttons.

... which happens to not have an associated menu, so this is likely the same issue the patch is fixing.
Comment 8 Giovanni Campagna 2012-10-26 13:34:10 UTC
Review of attachment 227348 [details] [review]:

Indeed.
Comment 9 Florian Müllner 2012-10-26 13:49:56 UTC
Attachment 227348 [details] pushed as 6f5e567 - panelMenu: Fix exception when destroying menuless button