After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686748 - Makefile.am: Fix build script typo for generating the Android.mk file.
Makefile.am: Fix build script typo for generating the Android.mk file.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
unspecified
Other Linux
: Normal normal
: 1.0.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-24 02:59 UTC by Scott Fan
Modified: 2012-10-24 13:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch file for fixing the Makefile.am files. (1.71 KB, application/octet-stream)
2012-10-24 02:59 UTC, Scott Fan 		  Details
Patch file for fixing the Makefile.am files. (2.24 KB, patch)
2012-10-24 03:17 UTC, Scott Fan 		none Details | Review
Patch for fixing typos in the Makefile.am files (2.51 KB, patch)
2012-10-24 12:23 UTC, Scott Fan 		committed Details | Review

Description Scott Fan 2012-10-24 02:59:14 UTC 
Created attachment 227115 [details]
Patch file for fixing the Makefile.am files.

In the Makefile.am file of the realmedia and asfdemux plugin, a typo for generating the Android.mk file had introduced for a long time when Android.mk section added. I found this bug in the 0.10, 0.11 and master branch(I didn't check other branches).
Comment 1 Scott Fan 2012-10-24 03:17:08 UTC 
Created attachment 227117 [details] [review]
Patch file for fixing the Makefile.am files.

This patch is in git format-patch format
Comment 2 Tim-Philipp Müller 2012-10-24 09:32:03 UTC 
Could you make a patch that applies to git master please? (though I suspect that needs some updating for 0.10 -> 1.0 anyway)

Also, the project + shared library name for asf should be libgstasfdemux -> libgstasf in addition to your changes.
Comment 3 Scott Fan 2012-10-24 12:23:30 UTC 
Created attachment 227138 [details] [review]
Patch for fixing typos in the Makefile.am files
Comment 4 Tim-Philipp Müller 2012-10-24 12:40:31 UTC 
Thanks!

commit bbe0cb04407262707643a6fcd0c3eaf65d6c3fa5
Author: Scott Fan <fanchp@neusoft.com>
Date:   Wed Oct 24 20:10:03 2012 +0800

    Makefile.am: Fix typos for generating the Android.mk files
    
    Change libgstasfdemux to libgstasf, and change libgstrealmedia to libgstrmdemux.
    
    The typos led to generate the incorrect Android.mk files for the asfdemux
    and realmedia plugin.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=686748
Comment 5 Scott Fan 2012-10-24 13:01:53 UTC 
(In reply to comment #4)
> Thanks!
> 
> commit bbe0cb04407262707643a6fcd0c3eaf65d6c3fa5
> Author: Scott Fan <fanchp@neusoft.com>
> Date:   Wed Oct 24 20:10:03 2012 +0800
> 
>     Makefile.am: Fix typos for generating the Android.mk files
> 
>     Change libgstasfdemux to libgstasf, and change libgstrealmedia to
> libgstrmdemux.
> 
>     The typos led to generate the incorrect Android.mk files for the asfdemux
>     and realmedia plugin.
> 
>     https://bugzilla.gnome.org/show_bug.cgi?id=686748

Could you also apply this patch to git 0.10 branch please? Indeed, I use the 0.10 branch for building Android plugins;

In all the Makefile.am files for Android, LOCAL_MODULE_PATH was defined as $(TARGET_OUT)/lib/gstreamer-0.10, I thought those would better change to $(TARGET_OUT)/lib/gstreamer-1.0 for 1.0
Comment 6 Tim-Philipp Müller 2012-10-24 13:08:09 UTC 
Done. Yes, someone needs to update all the android stuff for 1.0.