After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686642 - udpsrc: trivial typo causes compilation error
udpsrc: trivial typo causes compilation error
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.0.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-22 13:51 UTC by Sebastian Rasmussen
Modified: 2012-10-22 22:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch for fixing compilation error. (859 bytes, patch)
2012-10-22 13:57 UTC, Sebastian Rasmussen
committed Details | Review

Description Sebastian Rasmussen 2012-10-22 13:51:56 UTC
When I try to make gst-plugins-good using gcc 4.3.1 I see this:

make[5]: Entering directory `gst-plugins-good/build/host/gst/udp'
  CC     libgstudp_la-gstudpsrc.lo
cc1: warnings being treated as errors
gst-plugins-good/gst/udp/gstudpsrc.c: In function 'gst_udpsrc_create':
gst-plugins-good/gst/udp/gstudpsrc.c:365: error: 'ret' may be used uninitialized in this function
make[5]: *** [libgstudp_la-gstudpsrc.lo] Error 1

This is due to a trivial typo in gst_udpsrc_create() which I fix with the attached patch.
Comment 1 Sebastian Rasmussen 2012-10-22 13:57:52 UTC
Created attachment 226997 [details] [review]
Proposed patch for fixing compilation error.
Comment 2 Tim-Philipp Müller 2012-10-22 22:29:45 UTC
Thanks!

commit 9fc62a58e3a21ed3354225cc64cdeb6b865cd094
Author: Sebastian Rasmussen <sebrn@axis.com>
Date:   Mon Oct 22 15:54:17 2012 +0200

    updsrc: fix typo causing compilation error
    
    gstudpsrc.c: In function 'gst_udpsrc_create':
    gstudpsrc.c:365: error: 'ret' may be used uninitialized in this function
    
    https://bugzilla.gnome.org/show_bug.cgi?id=686642