GNOME Bugzilla – Bug 686450
port to python 3
Last modified: 2013-10-13 08:53:02 UTC
Created attachment 226801 [details] [review] python 3 patch Slowly rhythmbox should be ported to python 3 I used the official python 2 to python 3 porter for rhythmbox and ran it over the python files. (see patch) Sadly somehow it's still python 2 (at least the debug shell says so). But this need to be done in a second step. Ah, and before I forgot it: I use archlinux where python 3 is default. Executing PYTHON=/usr/bin/python3 before running the autogen.sh script is maybe needed.
Do we want to port exclusively to Python3 or support both Python 2 and 3 by running 2to3 during build?
Running 2to3 during build sounds like a terrible idea to me.
(In reply to comment #2) > Running 2to3 during build sounds like a terrible idea to me. If one wants to support both Python 2 and Python 3, that's the official way to do it: "The official way to support both Python 2 and Python 3 is to maintain the code in a version for Python 2 and convert it to Python 3 with the 2to3 tool." ~ http://python3porting.com/2to3.html Personally, I agree that 2to3 would get ugly really fast, and so RB should just migrate to Python 3. :)
Created attachment 255556 [details] [review] Fixes remaining Python 3 issues Hi guys, AFAICS there are still some remaining Python 3 issues, so I fixed them in attached patch. Please note, that they only work with Python 3, not Python 2 (but the previous commits made by others already make Rhythmbox only work with Python 3 anyway, so I guess this is ok).
Thanks for the patch. I took out the zeitgeist bit, since I had more extensive patches for that elsewhere, and pushed the rest as commit a988e23.