GNOME Bugzilla – Bug 686369
Don't use deprecated geocode_object_add() call
Last modified: 2013-11-18 16:30:30 UTC
Will be removed very soon.
Created attachment 226728 [details] [review] Don't use deprecated geocode_object_add() call The call was removed in favour of the geocode_object_new_for_params() function.
Actually, the call wasn't removed, it should just be used for bindings, preferably.
Review of attachment 226728 [details] [review]: Thanks for the patch, but it's incorrect. geocode_object_new_for_params() expects a hash table of strings packed into GValues, not just raw strings. I found that API awkward enough that I just opted for calling geocode_object_add() directly, which is all new_for_params() is doing internally.
Created attachment 227174 [details] [review] Don't use geocode_object_add() call It's a call that's mainly of use to bindings. Use geocode_object_new_for_params_str() instead.
Better? Not sure whether it's a gain to use this function to be honest.
Thanks. The patch is fine for Evolution 3.9.x but I'm not going to push our build requirements for 3.7/3.8 beyond what's available in GNOME 3.6. I guess it would be best for now to just pack the strings into GValues after all and use the new_for_params() function. I'll take care of it so I don't trouble you for another patch.
(In reply to comment #6) > The patch is fine for Evolution 3.9.x mbarnes: ping. That's now (and that's why Target Milestones could help).
Target is Evolution 3.11 now. https://mail.gnome.org/archives/evolution-hackers/2013-September/msg00001.html
*** This bug has been marked as a duplicate of bug 689055 ***