After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686148 - [patch] suggested parameters for gtkdoc-scangobj
[patch] suggested parameters for gtkdoc-scangobj
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: 1.19
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-15 12:36 UTC by Henrik Stokseth
Modified: 2013-05-31 11:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Implement the parameters. (2.50 KB, patch)
2012-10-15 22:07 UTC, Henrik Stokseth 		none Details | Review
Add support for CMake. (5.43 KB, patch)
2013-05-30 19:47 UTC, Henrik Stokseth 		committed Details | Review

Description Henrik Stokseth 2012-10-15 12:36:22 UTC 
recently added changed a software project i work on to use cmake.

while doing so i discovered cmake can't export environment variables, so i had to make a hack to be able to pass cflags and ldflags to gtkdoc-scangobj.

it would be nice if you could add --cflags= and --ldflags= parameters to gtkdoc-scangobj so that compiler flags can be passed on the command line.
Comment 1 Matthias Clasen 2012-10-15 20:35:26 UTC 
How about fixing cmake instead ?
Comment 2 Yeti 2012-10-15 20:43:37 UTC 
I don't think anyone can accuse me of liking cmake...  But still the passing of some arguments by environment variables instead of actual command line arguments has always struck me as odd.
Comment 3 Henrik Stokseth 2012-10-15 22:07:57 UTC 
Created attachment 226514 [details] [review]
Implement the parameters.

If parameter is given it overrides setting from environment variable, otherwise the environment variable is used.

The change is simple and does not break current scripts.
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2013-05-30 18:18:54 UTC 
Sounds reasonable. Could you please re-attach the patch in git format (git format-patch origin/master).
Comment 5 Henrik Stokseth 2013-05-30 19:47:54 UTC 
Created attachment 245673 [details] [review]
Add support for CMake.

Here you have a new patch, submitted in the requested fashion.
Comment 6 Stefan Sauer (gstreamer, gtkdoc dev) 2013-05-31 11:54:19 UTC 
Comment on attachment 245673 [details] [review]
Add support for CMake.

Thanks.