After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686086 - add context for unknown
add context for unknown
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2012-10-13 12:56 UTC by Pavol Klačanský
Modified: 2012-10-17 17:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add context for 'Unknown' and validity strings (5.40 KB, patch)
2012-10-13 19:08 UTC, Stef Walter 		committed Details | Review
Screenshot of one location 'Never' is used in validity context (19.82 KB, image/png)
2012-10-17 16:14 UTC, Stef Walter 		  Details

Description Pavol Klačanský 2012-10-13 12:56:25 UTC 
#: ../libseahorse/seahorse-validity.c:40 ../pgp/seahorse-gpgme-subkey.c:197
#: ../pgp/seahorse-pgp-key-properties.c:1254
#: ../pgp/seahorse-pgp-private-key-properties.xml.h:1
#: ../pgp/seahorse-pgp-public-key-properties.xml.h:1
#: ../pkcs11/seahorse-token.c:576
msgid "Unknown"


could you please add gettext context?
Comment 1 André Klapper 2012-10-13 15:26:56 UTC 
It's helpful to provide information for developers, in this case:
https://live.gnome.org/TranslationProject/DevGuidelines/Translation%20contexts
Comment 2 Stef Walter 2012-10-13 19:08:56 UTC 
Created attachment 226388 [details] [review]
Add context for 'Unknown' and validity strings
Comment 3 Stef Walter 2012-10-13 19:09:57 UTC 
Pavol, could you review the attached patch and make sure it fixes the issue in question?
Comment 4 Pavol Klačanský 2012-10-14 20:24:05 UTC 
yes, thank you
Comment 5 Stef Walter 2012-10-14 20:58:00 UTC 
Attachment 226388 [details] pushed as 0554925 - Add context for 'Unknown' and validity strings
Comment 6 Stef Walter 2012-10-14 20:59:10 UTC 
Comment on attachment 226388 [details] [review]
Add context for 'Unknown' and validity strings

Committed to seahorse git master.
Comment 7 Pavol Klačanský 2012-10-15 00:03:46 UTC 
can you post screenshot where these strings are displayed? (importing public key from search doesn't work)

also, is this string used in same context everywhere? can you post all screenshots with his occurence (I have checked source but I cannot get it working)
#: ../libseahorse/seahorse-validity.c:42
#: ../pgp/seahorse-pgp-key-properties.c:1260
#: ../pgp/seahorse-pgp-private-key-properties.xml.h:2
#: ../pgp/seahorse-pgp-public-key-properties.xml.h:2
msgctxt "Validity"
msgid "Never"

thanks
Comment 8 Stef Walter 2012-10-15 03:50:53 UTC 
(In reply to comment #7)
> can you post screenshot where these strings are displayed? (importing public
> key from search doesn't work)

Could you file a separate bug about what you tried here and why it didn't work? Thanks.
Comment 9 Pavol Klačanský 2012-10-17 15:25:47 UTC 
okay, could you please provide screenshot of particular string
Comment 10 Stef Walter 2012-10-17 16:14:48 UTC 
Created attachment 226654 [details]
Screenshot of one location 'Never' is used in validity context
Comment 11 Pavol Klačanský 2012-10-17 17:22:25 UTC 
thanks