After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686035 - Remove dependency on gtk+
Remove dependency on gtk+
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-10-12 14:54 UTC by Stef Walter
Modified: 2012-10-17 08:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove dependency on gtk+ (11.16 KB, patch)
2012-10-12 14:54 UTC, Stef Walter 		committed Details | Review

Description Stef Walter 2012-10-12 14:54:55 UTC 
We haven't needed GTK+ directly since the new prompt code, in 3.4.x
Comment 1 Stef Walter 2012-10-12 14:54:59 UTC 
Created attachment 226334 [details] [review]
Remove dependency on gtk+

 * We depend on gcr which has a dependency on gtk+ but we don't need
   to depend on it expcilitly.
 * Remove unused egg-secure-buffer.[ch] code.
Comment 2 Matthias Clasen 2012-10-15 18:14:47 UTC 
Review of attachment 226334 [details] [review]:

Looks right
Comment 3 Stef Walter 2012-10-17 08:11:23 UTC 
Attachment 226334 [details] pushed as 408f6ee - Remove dependency on gtk+
Comment 4 Stef Walter 2012-10-17 08:12:12 UTC 
Thanks for the review Matthias.